-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate build scripts over to CAKE #1440
Comments
Just on this point, I stumbled upon GitLink which sounds like it may do the same thing as what SourceLink currently does. CAKE has built-in aliases for GitLink |
@ryangribble if GitLink gives us the same end result, then I'm fine with switching. I forget the backstory and why they didn't team up with SourceLink way back in the day... |
Hmmm so it turns out both SourceLink and GitLink dont support dotnetcore project.json and .xproj files which is a bit of a bummer in terms of our own dotnetcore move (which isnt strictly related to moving to CAKE however I was kind of intending to do it all at the same time) GitLink aren't planning on doing anything until project.json goes away (although Im not sure when that actually will occur), and SourceLink were waiting for upstream depedencies as of a few months ago which are hopefully now in place so there could be hope there... |
Yo @shiftkey and @ryangribble I'd suggest using See https://github.com/reactiveui/ReactiveUI/blob/develop/GitReleaseManager.yaml and https://github.com/reactiveui/ReactiveUI/blob/develop/GitVersion.yml Doing +1 on using cake but steal the akavache implementation as it includes release workflows and automatic versioning - https://github.com/akavache/Akavache/blob/develop/build.cake +1 to using GitLink as SourceLink is weird with CRLF's. |
Additionally, once netstandard migration is done you can move 100% to appveyor and get rid of travisci. |
Yep all sounds good. The cake stuff i was playing with already is using GitVersion see here So far i mostly based my cake stuff off Bddfy cake scripts but I'll take a look at akavache |
Closed by #1581 |
I've had some interest from various corners about moving our build scripts over to Cake. The process seems very similar to what we're doing currently, so I'm not really going to stand in the way.
Things I'd like to verify are possible with Cake (mostly due to emulating our current flow for releasing things):
dotnet
CLI tools to build, rather than MSBuildAssemblyInfo
generation from ourReleaseNotes.md
fileAlso note that these things in the current scripts will be made redundant by the migration to using the
dotnet
CLI, so I wouldn't worry about investing too much time in porting them over:The text was updated successfully, but these errors were encountered: