Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Add support for xproj+project.json #83

Closed
xoofx opened this issue Apr 5, 2016 · 21 comments
Closed

Add support for xproj+project.json #83

xoofx opened this issue Apr 5, 2016 · 21 comments

Comments

@xoofx
Copy link

xoofx commented Apr 5, 2016

Hi there,
Currently GitLink only supports regular msbuild projects (e.g csproj), and not xproj projects (dnx projects and upcoming dotnet/cli projects). I'm currently migrating all my projects to this model but cannot use GitLink with them.
Could you consider adding support for this kind of projects?
Thanks!

@xoofx xoofx changed the title Add support for project.json Add support for xproj+project.json Apr 6, 2016
@GeertvanHorrik
Copy link
Contributor

We are definitely open for this

@hikalkan
Copy link
Contributor

Any update on that?

@GeertvanHorrik
Copy link
Contributor

We haven't seen a PR yet. But on the other hand, glad we skipped the project.json ride now it's being replaced by csproj again.

@hikalkan
Copy link
Contributor

Yes, it will be changed again. But for a few months (or more), there will be xproj files. Also, then csproj file will be different than current format. It would be good if GitLink supports both formats.

@hikalkan
Copy link
Contributor

If this will not take much time, I definetely would like this. Because all new projects with .NET Core / ASP.NET Core support have xproj format now and I believe it will not be changed in a very short time. So, it has worth to support it.
Actually I did try to make it but and made it running. But there were some problems on debugging (was skipping some lines) since I don't know code well.
Thanks.

@GeertvanHorrik
Copy link
Contributor

@hikalkan if you can create a pr with what you have so far, I am happy to help out and finish the feature together.

@hikalkan
Copy link
Contributor

OK, It was a few weeks ago, I will check it again.

@niemyjski
Copy link

+1

@ejsmith
Copy link

ejsmith commented Aug 29, 2016

Don't think it makes sense to do any work on this until they finalizing the new tooling.

@GeertvanHorrik
Copy link
Contributor

Agree. It's a lot of work to implement this, from what I understood the project.json is going away again and being replaced by xproj.

@ghuntley
Copy link
Contributor

ghuntley commented Sep 4, 2016

Agree project.json is still a bowl of jello. When it settles 3 cute kittens will be awarded to the victor (whomever raises and merges the PR).

@niemyjski
Copy link

@ghuntley does that include shots and free shipping?

@wocar
Copy link

wocar commented Dec 5, 2016

Any updates?

@GeertvanHorrik
Copy link
Contributor

We are working on a version of GitLink that is solution / project unaware and only needs pdb files to work with. This would make this need redundant. It's WIP though.

@wocar
Copy link

wocar commented Dec 13, 2016

Any updates on this hehe?? Should we put a bounty on the PR $ 😝😁 I'm down for it

@ejsmith
Copy link

ejsmith commented Dec 13, 2016

Why would anyone work on this now? Project.json is about to be gone. Plus they said they are working on changes that will make it just work off the pdbs and not need the project

@ghuntley
Copy link
Contributor

My vote is wait until 2017 is out/stable.

@niemyjski
Copy link

@ghuntley It should be good to work with the latest rc drop :)

@DanielBryars
Copy link

Do you have the version where you can specify the pdb file directly in a branch? I'd like to play with it?

@GeertvanHorrik
Copy link
Contributor

@DanielBryars Yep, the current develop branch is that one. It's already available as pre-release on NuGet & Chocolatey as well.

@GeertvanHorrik
Copy link
Contributor

GitLink 3.0 has just been released. I think this ticket can now be closed. If not, please feel free to comment / re-open.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants