Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRepositoriesClient.Commits -> IRepositoriesClient.Commit #1035

Closed
shiftkey opened this issue Dec 23, 2015 · 1 comment
Closed

IRepositoriesClient.Commits -> IRepositoriesClient.Commit #1035

shiftkey opened this issue Dec 23, 2015 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Milestone

Comments

@shiftkey
Copy link
Member

This is a pluralized interface that we shouldn't really have:

https://developer.github.com/v3/repos/commits/

var commit = await github.Repository.Commits.Get("octokit", "octokit.net", "master");

We should mark this property as obsolete and introduce a new property which is singular:

var commit = await github.Repository.Commit.Get("octokit", "octokit.net", "master");
@shiftkey shiftkey modified the milestone: API Cleanup Dec 23, 2015
@M-Zuber
Copy link
Contributor

M-Zuber commented Dec 23, 2015

🎋

M-Zuber added a commit to M-Zuber/octokit.net that referenced this issue Dec 23, 2015
@haacked haacked closed this as completed in b191736 Jan 3, 2016
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants