Release v0.28 - Get to the Chopper!!! (#1709)

* Update release notes * fix whitespace
octokit · Nov 6, 2017 · ed1feb6 · ed1feb6
1 parent 3b26177
commit ed1feb6
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/Octokit.Reactive/IObservableGitHubClient.cs b/Octokit.Reactive/IObservableGitHubClient.cs
@@ -15,7 +15,7 @@ public interface IObservableGitHubClient : IApiInfoProvider
         /// </remarks>
         /// <param name="timeout">The Timeout value</param>
         void SetRequestTimeout(TimeSpan timeout);
-        
+
         IObservableAuthorizationsClient Authorization { get; }
         IObservableActivitiesClient Activity { get; }
         IObservableIssuesClient Issue { get; }

diff --git a/Octokit.Reactive/ObservableGitHubClient.cs b/Octokit.Reactive/ObservableGitHubClient.cs
@@ -64,7 +64,6 @@ public IConnection Connection
         /// <param name="timeout">The Timeout value</param>
         public void SetRequestTimeout(TimeSpan timeout)
         {
-
             _gitHubClient.SetRequestTimeout(timeout);
         }
 

diff --git a/Octokit/IGitHubClient.cs b/Octokit/IGitHubClient.cs
@@ -16,7 +16,7 @@ public interface IGitHubClient : IApiInfoProvider
         /// </remarks>
         /// <param name="timeout">The Timeout value</param>
         void SetRequestTimeout(TimeSpan timeout);
-        
+
         /// <summary>
         /// Provides a client connection to make rest requests to HTTP endpoints.
         /// </summary>

diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -1,3 +1,23 @@
+### New in 0.28.0 (released 6/11/2017)
+
+## Advisories and Breaking Changes
+
+- This release has been pushed out in response to `CommitStatus.Id` on GitHub exceeding `Int32.MaxValue`.  We've made this field a `long` now... sorry about that!
+
+## Release Notes
+
+**Features/Enhancements**
+
+- You can now use `IGitHubClient.SetRequestTimeout(TimeSpan timeout)` to set a custom timeout, particularly useful for lengthy operations such as uploading release assets. - [#1693](https://github.com/octokit/octokit.net/pull/1693) via [@pmiossec](https://github.com/pmiossec), [@ryangribble](https://github.com/ryangribble)
+
+**Fixes**
+
+- Update `CommitStatus.Id` field from `int` to `long` to prevent overflow exceptions - [#1703](https://github.com/octokit/octokit.net/pull/1703) via [@kzu](https://github.com/kzu)
+
+**Housekeeping**
+
+- Correct rendering of `HttpClient` documentation page - [#1699](https://github.com/octokit/octokit.net/pull/1699) via [@scovetta](https://github.com/scovetta)
+
 ### New in 0.27.0 (released 7/10/2017)
 
 ## Advisories and Breaking Changes
-Original file line number
+Diff line change
@@ Expand Up / @@ -64,7 +64,6 @@ public IConnection Connection @@
             /// <param name="timeout">The Timeout value</param>
             public void SetRequestTimeout(TimeSpan timeout)
             {
                 _gitHubClient.SetRequestTimeout(timeout);
             }
@@ Expand Down @@