Skip to content

Commit

Permalink
build(deps): bump xunit from 2.6.1 to 2.6.3 (#2834)
Browse files Browse the repository at this point in the history
* build(deps): bump xunit from 2.6.1 to 2.6.3

Bumps [xunit](https://github.com/xunit/xunit) from 2.6.1 to 2.6.3.
- [Commits](xunit/xunit@2.6.1...2.6.3)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add required async/awaits

* public async void --> public async Task

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Keegan Campbell <[email protected]>
  • Loading branch information
dependabot[bot] and kfcampbell authored Dec 18, 2023
1 parent 849be93 commit c895ac8
Show file tree
Hide file tree
Showing 9 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="xunit" Version="2.6.1" />
<PackageReference Include="xunit" Version="2.6.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.5" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion Octokit.Tests.Integration/Clients/ReleasesClientTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public async Task CreateReleaseAsLatest()
var firstReleaseRequest = new NewRelease("0.1") { MakeLatest = MakeLatestQualifier.False };
await _releaseClient.Create(_context.Repository.Id, firstReleaseRequest);

Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.GetLatest(_context.RepositoryOwner, _context.RepositoryName));
await Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.GetLatest(_context.RepositoryOwner, _context.RepositoryName));

var secondReleaseRequest = new NewRelease("0.2") { MakeLatest = MakeLatestQualifier.True };
var secondRelease = await _releaseClient.Create(_context.Repository.Id, secondReleaseRequest);
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Tests.Integration/Octokit.Tests.Integration.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<PackageReference Include="GitHubJwt" Version="0.0.6" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="System.IO.Compression" Version="4.3.0" />
<PackageReference Include="xunit" Version="2.6.1" />
<PackageReference Include="xunit" Version="2.6.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.5" />
</ItemGroup>

Expand Down
6 changes: 3 additions & 3 deletions Octokit.Tests/AsyncEnumerableExtensionTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ public class AsyncEnumerableExtensionTests
public class ThePaginatedList
{
[Fact]
public void RejectsInvalidValues()
public async Task RejectsInvalidValues()
{
var client = Substitute.For<IRepositoriesClient>();

Assert.ThrowsAsync<ArgumentOutOfRangeException>(() => client.GetAllForOrgAsync("octokit")[-1]);
await Assert.ThrowsAsync<ArgumentOutOfRangeException>(() => client.GetAllForOrgAsync("octokit")[-1]);
}

[Fact]
Expand Down Expand Up @@ -72,7 +72,7 @@ public class ThePaginationOverloads
public void RejectInvalidValues()
{
var client = Substitute.For<IRepositoriesClient>();

Assert.Throws<ArgumentOutOfRangeException>(() => client.GetAllForUserAsync("fake", -1));
Assert.Throws<ArgumentOutOfRangeException>(() => client.GetAllForUserAsync("fake", 0));
}
Expand Down
4 changes: 2 additions & 2 deletions Octokit.Tests/Caching/CachingHttpClientTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class CachingHttpClientTests
public class TheSendMethod
{
[Fact]
public void EnsuresNonNullArguments()
public async Task EnsuresNonNullArguments()
{
// arrange
var underlyingClient = Substitute.For<IHttpClient>();
Expand All @@ -29,7 +29,7 @@ public void EnsuresNonNullArguments()
var cachingHttpClient = new CachingHttpClient(underlyingClient, responseCache);

// act + assert
Assert.ThrowsAsync<ArgumentNullException>(() => cachingHttpClient.Send(null, CancellationToken.None));
await Assert.ThrowsAsync<ArgumentNullException>(() => cachingHttpClient.Send(null, CancellationToken.None));
}

[Theory]
Expand Down
4 changes: 2 additions & 2 deletions Octokit.Tests/Clients/LicensesClientTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ public void EnsuresNonNullArguments()
public class TheGetAllLicensesMethod
{
[Fact]
public void EnsuresNonNullArguments()
public async Task EnsuresNonNullArguments()
{
var client = new LicensesClient(Substitute.For<IApiConnection>());

Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
}

[Fact]
Expand Down
4 changes: 2 additions & 2 deletions Octokit.Tests/Clients/MiscellaneousClientTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -207,11 +207,11 @@ public void EnsuresNonNullArguments()
public class TheGetAllLicensesMethod
{
[Fact]
public void EnsuresNonNullArguments()
public async Task EnsuresNonNullArguments()
{
var client = new MiscellaneousClient(Substitute.For<IApiConnection>());

Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
}

[Fact]
Expand Down
16 changes: 8 additions & 8 deletions Octokit.Tests/Clients/OrganizationHooksClientTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@ public async Task EnsuresNonNullArguments()
}

[Fact]
public void EnsuresNonEmptyArguments()
public async Task EnsuresNonEmptyArguments()
{
var client = new OrganizationsClient(Substitute.For<IApiConnection>());
var config = new Dictionary<string, string> { { "url", "" } };
Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Create("", new NewOrganizationHook("name", config)));
await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Create("", new NewOrganizationHook("name", config)));
}

[Fact]
Expand Down Expand Up @@ -167,10 +167,10 @@ public async Task EnsuresNonNullArguments()
}

[Fact]
public void EnsuresNonEmptyArguments()
public async Task EnsuresNonEmptyArguments()
{
var client = new OrganizationsClient(Substitute.For<IApiConnection>());
Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Edit("", 123, new EditOrganizationHook()));
await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Edit("", 123, new EditOrganizationHook()));
}

[Fact]
Expand All @@ -197,10 +197,10 @@ public async Task EnsuresNonNullArguments()
}

[Fact]
public void EnsuresNonEmptyArguments()
public async Task EnsuresNonEmptyArguments()
{
var client = new OrganizationsClient(Substitute.For<IApiConnection>());
Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Ping("", 123));
await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Ping("", 123));
}

[Fact]
Expand Down Expand Up @@ -237,10 +237,10 @@ public async Task EnsuresNonNullArguments()
}

[Fact]
public void EnsuresNonEmptyArguments()
public async Task EnsuresNonEmptyArguments()
{
var client = new OrganizationsClient(Substitute.For<IApiConnection>());
Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Delete("", 123));
await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Delete("", 123));
}

}
Expand Down
2 changes: 1 addition & 1 deletion Octokit.Tests/Octokit.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="xunit" Version="2.6.1" />
<PackageReference Include="xunit" Version="2.6.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.5" />
</ItemGroup>

Expand Down

0 comments on commit c895ac8

Please sign in to comment.