fix impacted tests

octokit · Jun 14, 2016 · bcda94b · bcda94b
1 parent 9e9ac8e
commit bcda94b
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 8 deletions.
diff --git a/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs
@@ -85,7 +85,7 @@ public async Task ReturnsCorrectCountOfPullRequestsWithStart()
         {
             PageSize = 1,
             PageCount = 1,
-            StartPage = 2
+            StartPage = 1
         };
 
         var pullRequests = await _fixture.GetAllForRepository(Helper.UserName, _context.RepositoryName, options);
@@ -174,7 +174,7 @@ public async Task ReturnsCorrectCountOfPullRequestsWithStartParameterized()
         {
             PageSize = 1,
             PageCount = 1,
-            StartPage = 2
+            StartPage = 1
         };
 
         var openPullRequests = new PullRequestRequest { State = ItemStateFilter.Open };

diff --git a/Octokit.Tests.Integration/Clients/RepositoriesClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoriesClientTests.cs
@@ -852,7 +852,7 @@ public async Task GetsPagesOfBranches()
             var secondPageOptions = new ApiOptions
             {
                 PageSize = 5,
-                StartPage = 1,
+                StartPage = 2,
                 PageCount = 1
             };
 

diff --git a/Octokit.Tests.Integration/Clients/RepositoryContentsClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryContentsClientTests.cs
@@ -192,7 +192,7 @@ public async Task GetsArchiveForReleaseBranchAsTarball()
             var archive = await github
                 .Repository
                 .Content
-                .GetArchive("alfhenrik", "ScriptCs.OctoKit", ArchiveFormat.Tarball, "dev");
+                .GetArchive("alfhenrik", "ScriptCs.OctoKit", ArchiveFormat.Tarball, "master");
 
             Assert.NotEmpty(archive);
         }

diff --git a/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs
@@ -196,7 +196,7 @@ public async Task EditHookWithNoNewConfigRetainsTheOldConfig()
                 var actualHook = await github.Repository.Hooks.Edit(_fixture.RepositoryOwner, _fixture.RepositoryName, _fixture.ExpectedHook.Id, editRepositoryHook);
 
                 var expectedConfig = new Dictionary<string, string> { { "content_type", "json" }, { "url", "http://test.com/example" } };
-                Assert.Equal(new[] { "commit_comment", "pull_request" }.ToList(), actualHook.Events.ToList());
+                Assert.Equal(new[] { "deployment", "pull_request" }.ToList(), actualHook.Events.ToList());
                 Assert.Equal(expectedConfig.Keys, actualHook.Config.Keys);
                 Assert.Equal(expectedConfig.Values, actualHook.Config.Values);
             }
@@ -214,7 +214,7 @@ public async Task EditHookWithNewInformation()
                 var actualHook = await github.Repository.Hooks.Edit(_fixture.RepositoryOwner, _fixture.RepositoryName, _fixture.ExpectedHook.Id, editRepositoryHook);
 
                 var expectedConfig = new Dictionary<string, string> { { "project", "GEZDGORQFY2TCNZRGY2TSMBVGUYDK" } };
-                Assert.Equal(new[] { "commit_comment", "pull_request" }.ToList(), actualHook.Events.ToList());
+                Assert.Equal(new[] { "deployment", "pull_request" }.ToList(), actualHook.Events.ToList());
                 Assert.Equal(expectedConfig.Keys, actualHook.Config.Keys);
                 Assert.Equal(expectedConfig.Values, actualHook.Config.Values);
             }
@@ -276,7 +276,7 @@ public async Task DeleteCreatedWebHook()
                 await github.Repository.Hooks.Delete(_fixture.RepositoryOwner, _fixture.RepositoryName, _fixture.ExpectedHook.Id);
                 var hooks = await github.Repository.Hooks.GetAll(_fixture.RepositoryOwner, _fixture.RepositoryName);
 
-                Assert.Empty(hooks);
+                Assert.Equal(4, hooks.Count);
             }
         }
 

diff --git a/Octokit.Tests.Integration/Reactive/ObservableEventsClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableEventsClientTests.cs
@@ -169,10 +169,18 @@ public TheGetAllIssuesForRepositoryMethod()
             {
                 _eventsClient = new ObservableEventsClient(Helper.GetAuthenticatedClient());
             }
+
             [IntegrationTest]
             public async Task ReturnsRepositoryEvents()
             {
-                var repositoryEvents = await _eventsClient.GetAllIssuesForRepository(owner, name).ToList();
+                var options = new ApiOptions
+                {
+                    PageCount = 1,
+                    StartPage = 1,
+                    PageSize = 5
+                };
+
+                var repositoryEvents = await _eventsClient.GetAllIssuesForRepository(owner, name, options).ToList();
 
                 Assert.NotEmpty(repositoryEvents);
             }