Merge pull request #1422 from TattsGroup/out-with-the-old

Remove Obsolete items
octokit · Jul 17, 2016 · 75bd374 · 75bd374
2 parents b47b054 + 9d8e8ae
commit 75bd374
Show file tree

Hide file tree

Showing 37 changed files with 0 additions and 1,142 deletions.
diff --git a/Octokit.Reactive/Clients/IObservableAuthorizationsClient.cs b/Octokit.Reactive/Clients/IObservableAuthorizationsClient.cs
@@ -213,18 +213,6 @@ IObservable<ApplicationAuthorization> GetOrCreateApplicationAuthentication(
         /// <returns></returns>
         IObservable<Unit> RevokeApplicationAuthentication(string clientId, string accessToken);
 
-        /// <summary>
-        /// Revokes every OAuth token for an OAuth application.
-        /// </summary>
-        /// <remarks>
-        /// This method requires authentication.
-        /// See the <a href="https://developer.github.com/v3/oauth_authorizations/#revoke-all-authorizations-for-an-application">API documentation for more information.</a>
-        /// </remarks>
-        /// <param name="clientId">ClientID of the OAuth application for the token</param>
-        /// <returns></returns>
-        [Obsolete("This feature is no longer supported in the GitHub API and will be removed in a future release")]
-        IObservable<Unit> RevokeAllApplicationAuthentications(string clientId);
-
         /// <summary>
         /// Update the <see cref="Authorization"/> specified by the id.
         /// </summary>

diff --git a/Octokit.Reactive/Clients/IObservableRepositoriesClient.cs b/Octokit.Reactive/Clients/IObservableRepositoriesClient.cs
@@ -150,17 +150,6 @@ public interface IObservableRepositoriesClient
         /// <returns>A <see cref="IReadOnlyPagedCollection{Repository}"/> of <see cref="Repository"/>.</returns>
         IObservable<Repository> GetAllForOrg(string organization, ApiOptions options);
 
-        /// <summary>
-        /// A client for GitHub's Commit Status API.
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/statuses/">Commit Status API documentation</a> for more
-        /// details. Also check out the <a href="https://github.com/blog/1227-commit-status-api">blog post</a> 
-        /// that announced this feature.
-        /// </remarks>
-        [Obsolete("Use Status instead")]
-        IObservableCommitStatusClient CommitStatus { get; }
-
         /// <summary>
         /// A client for GitHub's Commit Status API.
         /// </summary>
@@ -187,15 +176,6 @@ public interface IObservableRepositoriesClient
         ///</remarks>
         IObservableStatisticsClient Statistics { get; }
 
-        /// <summary>
-        /// Client for GitHub's Repository Comments API.
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/comments/">Repository Comments API documentation</a> for more information.
-        /// </remarks>
-        [Obsolete("Comment information is now available under the Comment property. This will be removed in a future update.")]
-        IObservableRepositoryCommentsClient RepositoryComments { get; }
-
         /// <summary>
         /// Client for GitHub's Repository Comments API.
         /// </summary>
@@ -540,15 +520,6 @@ public interface IObservableRepositoriesClient
         /// <returns>The updated <see cref="T:Octokit.Branch"/></returns>
         IObservable<Branch> EditBranch(int repositoryId, string branch, BranchUpdate update);
 
-        /// <summary>
-        /// A client for GitHub's Repo Collaborators.
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/collaborators/">Collaborators API documentation</a> for more details
-        /// </remarks>
-        [Obsolete("Collaborator information is now available under the Collaborator property. This will be removed in a future update.")]
-        IObservableRepoCollaboratorsClient RepoCollaborators { get; }
-
         /// <summary>
         /// A client for GitHub's Repo Collaborators.
         /// </summary>
@@ -557,15 +528,6 @@ public interface IObservableRepositoriesClient
         /// </remarks>
         IObservableRepoCollaboratorsClient Collaborator { get; }
 
-        /// <summary>
-        /// Client for GitHub's Repository Commits API
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/commits/">Commits API documentation</a> for more details
-        ///</remarks>
-        [Obsolete("Commit information is now available under the Commit property. This will be removed in a future update.")]
-        IObservableRepositoryCommitsClient Commits { get; }
-
         /// <summary>
         /// Client for GitHub's Repository Commits API
         /// </summary>

diff --git a/Octokit.Reactive/Clients/IObservableSshKeysClient.cs b/Octokit.Reactive/Clients/IObservableSshKeysClient.cs
diff --git a/Octokit.Reactive/Clients/ObservableAuthorizationsClient.cs b/Octokit.Reactive/Clients/ObservableAuthorizationsClient.cs
@@ -301,24 +301,6 @@ public IObservable<Unit> RevokeApplicationAuthentication(string clientId, string
                 .ToObservable();
         }
 
-        /// <summary>
-        /// Revokes every OAuth token for an OAuth application.
-        /// </summary>
-        /// <remarks>
-        /// This method requires authentication.
-        /// See the <a href="https://developer.github.com/v3/oauth_authorizations/#revoke-all-authorizations-for-an-application">API documentation for more information.</a>
-        /// </remarks>
-        /// <param name="clientId">ClientID of the OAuth application for the token</param>
-        /// <returns></returns>
-        [Obsolete("This feature is no longer supported in the GitHub API and will be removed in a future release")]
-        public IObservable<Unit> RevokeAllApplicationAuthentications(string clientId)
-        {
-            Ensure.ArgumentNotNullOrEmptyString("clientId", clientId);
-
-            return _client.RevokeAllApplicationAuthentications(clientId)
-                .ToObservable();
-        }
-
         /// <summary>
         /// Update the <see cref="Authorization"/> specified by the id.
         /// </summary>

diff --git a/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs b/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs
@@ -22,20 +22,11 @@ public ObservableRepositoriesClient(IGitHubClient client)
             Status = new ObservableCommitStatusClient(client);
             Hooks = new ObservableRepositoryHooksClient(client);
             Forks = new ObservableRepositoryForksClient(client);
-#pragma warning disable CS0618 // Type or member is obsolete
-            RepoCollaborators = new ObservableRepoCollaboratorsClient(client);
-#pragma warning restore CS0618 // Type or member is obsolete
             Collaborator = new ObservableRepoCollaboratorsClient(client);
             Deployment = new ObservableDeploymentsClient(client);
             Statistics = new ObservableStatisticsClient(client);
             PullRequest = new ObservablePullRequestsClient(client);
-#pragma warning disable CS0618 // Type or member is obsolete
-            RepositoryComments = new ObservableRepositoryCommentsClient(client);
-#pragma warning restore CS0618 // Type or member is obsolete
             Comment = new ObservableRepositoryCommentsClient(client);
-#pragma warning disable CS0618 // Type or member is obsolete
-            Commits = new ObservableRepositoryCommitsClient(client);
-#pragma warning restore CS0618 // Type or member is obsolete
             Commit = new ObservableRepositoryCommitsClient(client);
             Release = new ObservableReleasesClient(client);
             DeployKeys = new ObservableRepositoryDeployKeysClient(client);
@@ -264,17 +255,6 @@ public IObservable<Repository> GetAllForOrg(string organization, ApiOptions opti
             return _connection.GetAndFlattenAllPages<Repository>(ApiUrls.OrganizationRepositories(organization), options);
         }
 
-        /// <summary>
-        /// A client for GitHub's Commit Status API.
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/statuses/">Commit Status API documentation</a> for more
-        /// details. Also check out the <a href="https://github.com/blog/1227-commit-status-api">blog post</a> 
-        /// that announced this feature.
-        /// </remarks>
-        [Obsolete("Use Status instead")]
-        public IObservableCommitStatusClient CommitStatus { get { return Status; } }
-
         /// <summary>
         /// A client for GitHub's Commit Status API.
         /// </summary>
@@ -301,15 +281,6 @@ public IObservable<Repository> GetAllForOrg(string organization, ApiOptions opti
         ///</remarks>
         public IObservableStatisticsClient Statistics { get; private set; }
 
-        /// <summary>
-        /// Client for GitHub's Repository Comments API.
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/comments/">Repository Comments API documentation</a> for more information.
-        /// </remarks>
-        [Obsolete("Comment information is now available under the Comment property. This will be removed in a future update.")]
-        public IObservableRepositoryCommentsClient RepositoryComments { get; private set; }
-
         /// <summary>
         /// Client for GitHub's Repository Comments API.
         /// </summary>
@@ -836,15 +807,6 @@ public IObservable<CompareResult> Compare(string owner, string name, string @bas
             return _client.Commit.Compare(owner, name, @base, head).ToObservable();
         }
 
-        /// <summary>
-        /// A client for GitHub's Repo Collaborators.
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/collaborators/">Collaborators API documentation</a> for more details
-        /// </remarks>
-        [Obsolete("Collaborator information is now available under the Collaborator property. This will be removed in a future update.")]
-        public IObservableRepoCollaboratorsClient RepoCollaborators { get; private set; }
-
         /// <summary>
         /// A client for GitHub's Repo Collaborators.
         /// </summary>
@@ -853,15 +815,6 @@ public IObservable<CompareResult> Compare(string owner, string name, string @bas
         /// </remarks>
         public IObservableRepoCollaboratorsClient Collaborator { get; private set; }
 
-        /// <summary>
-        /// Client for GitHub's Repository Commits API
-        /// </summary>
-        /// <remarks>
-        /// See the <a href="http://developer.github.com/v3/repos/commits/">Commits API documentation</a> for more details
-        ///</remarks>
-        [Obsolete("Commit information is now available under the Commit property. This will be removed in a future update.")]
-        public IObservableRepositoryCommitsClient Commits { get; private set; }
-
         /// <summary>
         /// Client for GitHub's Repository Commits API
         /// </summary>

diff --git a/Octokit.Reactive/Clients/ObservableSshKeysClient.cs b/Octokit.Reactive/Clients/ObservableSshKeysClient.cs
diff --git a/Octokit.Reactive/IObservableGitHubClient.cs b/Octokit.Reactive/IObservableGitHubClient.cs
@@ -15,15 +15,8 @@ public interface IObservableGitHubClient : IApiInfoProvider
         IObservablePullRequestsClient PullRequest { get; }
         IObservableRepositoriesClient Repository { get; }
         IObservableGistsClient Gist { get; }
-        [Obsolete("Use Repository.Release instead")]
-        IObservableReleasesClient Release { get; }
-        IObservableSshKeysClient SshKey { get; }
         IObservableUsersClient User { get; }
-        [Obsolete("Notifications are now available under the Activities client. This will be removed in a future update.")]
-        IObservableNotificationsClient Notification { get; }
         IObservableGitDatabaseClient Git { get; }
-        [Obsolete("Use Git instead")]
-        IObservableGitDatabaseClient GitDatabase { get; }
         IObservableSearchClient Search { get; }
         IObservableEnterpriseClient Enterprise { get; }
         IObservableMigrationClient Migration { get; }