Add tests for observable repository branches client, leave old tests …

…in place for now
octokit · Aug 8, 2016 · 6e6b9d6 · 6e6b9d6
1 parent 7f72b64
commit 6e6b9d6
Show file tree

Hide file tree

Showing 3 changed files with 205 additions and 4 deletions.
diff --git a/Octokit.Tests/Octokit.Tests.csproj b/Octokit.Tests/Octokit.Tests.csproj
@@ -240,6 +240,7 @@
     <Compile Include="Reactive\ObservablePullRequestsClientTests.cs" />
     <Compile Include="Reactive\ObservableReleasesClientTests.cs" />
     <Compile Include="Reactive\ObservablePullRequestReviewCommentsClientTests.cs" />
+    <Compile Include="Reactive\ObservableRepositoryBranchesClientTests.cs" />
     <Compile Include="Reactive\ObservableRepositoriesClientTests.cs" />
     <Compile Include="Reactive\ObservableRepositoryCommentsClientTests.cs" />
     <Compile Include="Reactive\ObservableIssuesEventsClientTests.cs" />

diff --git a/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs b/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs
@@ -848,7 +848,7 @@ public void RequestsTheCorrectUrl()
 
                 client.GetBranch("owner", "repo", "branch");
 
-                github.Repository.Received(1).GetBranch("owner", "repo", "branch");
+                github.Repository.Branch.Received(1).Get("owner", "repo", "branch");
             }
 
             [Fact]
@@ -859,7 +859,7 @@ public void RequestsTheCorrectUrlWithRepositoryId()
 
                 client.GetBranch(1, "branch");
 
-                github.Repository.Received(1).GetBranch(1, "branch");
+                github.Repository.Branch.Received(1).Get(1, "branch");
             }
 
             [Fact]
@@ -935,7 +935,7 @@ public void PatchsTheCorrectUrl()
 
                 client.EditBranch("owner", "repo", "branch", update);
 
-                github.Repository.Received(1).EditBranch("owner", "repo", "branch", update);
+                github.Repository.Branch.Received(1).Edit("owner", "repo", "branch", update);
             }
 
             [Fact]
@@ -947,7 +947,7 @@ public void PatchsTheCorrectUrlWithRepositoryId()
 
                 client.EditBranch(1, "branch", update);
 
-                github.Repository.Received(1).EditBranch(1, "branch", update);
+                github.Repository.Branch.Received(1).Edit(1, "branch", update);
             }
 
             [Fact]

diff --git a/Octokit.Tests/Reactive/ObservableRepositoryBranchesClientTests.cs b/Octokit.Tests/Reactive/ObservableRepositoryBranchesClientTests.cs
@@ -0,0 +1,200 @@
+using System;
+using System.Collections.Generic;
+using System.Reactive.Linq;
+using System.Threading.Tasks;
+using NSubstitute;
+using Octokit.Internal;
+using Octokit.Reactive;
+using Xunit;
+
+namespace Octokit.Tests.Reactive
+{
+    public class ObservableRepositoryBranchesClientTests
+    {
+        public class TheCtor
+        {
+            [Fact]
+            public void EnsuresNonNullArguments()
+            {
+                Assert.Throws<ArgumentNullException>(
+                    () => new ObservableRepositoryBranchesClient(null));
+            }
+        }
+
+        public class TheGetAllMethod
+        {
+            [Fact]
+            public void RequestsTheCorrectUrl()
+            {
+                var gitHubClient = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(gitHubClient);
+                var expected = new Uri("repos/owner/repo/branches", UriKind.Relative);
+
+                client.GetAll("owner", "repo");
+
+                gitHubClient.Connection.Received(1).Get<List<Branch>>(expected, Args.EmptyDictionary, null);
+            }
+
+            [Fact]
+            public void RequestsTheCorrectUrlWithRepositoryId()
+            {
+                var gitHubClient = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(gitHubClient);
+                var expected = new Uri("repositories/1/branches", UriKind.Relative);
+
+                client.GetAll(1);
+
+                gitHubClient.Connection.Received(1).Get<List<Branch>>(expected, Args.EmptyDictionary, null);
+            }
+
+            [Fact]
+            public void RequestsTheCorrectUrlWithApiOptions()
+            {
+                var gitHubClient = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(gitHubClient);
+                var expected = new Uri("repos/owner/name/branches", UriKind.Relative);
+
+                var options = new ApiOptions
+                {
+                    PageCount = 1,
+                    StartPage = 1,
+                    PageSize = 1
+                };
+
+                client.GetAll("owner", "name", options);
+
+                gitHubClient.Connection.Received(1).Get<List<Branch>>(expected, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["page"] == "1" && d["per_page"] == "1"), null);
+            }
+
+            [Fact]
+            public void RequestsTheCorrectUrlWithRepositoryIdWithApiOptions()
+            {
+                var gitHubClient = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(gitHubClient);
+                var expected = new Uri("repositories/1/branches", UriKind.Relative);
+
+                var options = new ApiOptions
+                {
+                    PageCount = 1,
+                    StartPage = 1,
+                    PageSize = 1
+                };
+
+                client.GetAll(1, options);
+
+                gitHubClient.Connection.Received(1).Get<List<Branch>>(expected, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["page"] == "1" && d["per_page"] == "1"), null);
+            }
+
+            [Fact]
+            public void EnsuresNonNullArguments()
+            {
+                var client = new ObservableRepositoryBranchesClient(Substitute.For<IGitHubClient>());
+
+                Assert.Throws<ArgumentNullException>(() => client.GetAll(null, "name"));
+                Assert.Throws<ArgumentNullException>(() => client.GetAll("owner", null));
+
+                Assert.Throws<ArgumentNullException>(() => client.GetAll(null, "name", ApiOptions.None));
+                Assert.Throws<ArgumentNullException>(() => client.GetAll("owner", null, ApiOptions.None));
+                Assert.Throws<ArgumentNullException>(() => client.GetAll("owner", "name", null));
+
+                Assert.Throws<ArgumentNullException>(() => client.GetAll(1, null));
+
+                Assert.Throws<ArgumentException>(() => client.GetAll("", "name"));
+                Assert.Throws<ArgumentException>(() => client.GetAll("owner", ""));
+                Assert.Throws<ArgumentException>(() => client.GetAll("", "name", ApiOptions.None));
+                Assert.Throws<ArgumentException>(() => client.GetAll("owner", "", ApiOptions.None));
+            }
+        }
+
+        public class TheGetMethod
+        {
+            [Fact]
+            public void RequestsTheCorrectUrl()
+            {
+                var github = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(github);
+
+                client.Get("owner", "repo", "branch");
+
+                github.Repository.Branch.Received(1).Get("owner", "repo", "branch");
+            }
+
+            [Fact]
+            public void RequestsTheCorrectUrlWithRepositoryId()
+            {
+                var github = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(github);
+
+                client.Get(1, "branch");
+
+                github.Repository.Branch.Received(1).Get(1, "branch");
+            }
+
+            [Fact]
+            public async Task EnsuresNonNullArguments()
+            {
+                var client = new ObservableRepositoryBranchesClient(Substitute.For<IGitHubClient>());
+
+                Assert.Throws<ArgumentNullException>(() => client.Get(null, "repo", "branch"));
+                Assert.Throws<ArgumentNullException>(() => client.Get("owner", null, "branch"));
+                Assert.Throws<ArgumentNullException>(() => client.Get("owner", "repo", null));
+
+                Assert.Throws<ArgumentNullException>(() => client.Get(1, null));
+
+                Assert.Throws<ArgumentException>(() => client.Get("", "repo", "branch"));
+                Assert.Throws<ArgumentException>(() => client.Get("owner", "", "branch"));
+                Assert.Throws<ArgumentException>(() => client.Get("owner", "repo", ""));
+
+                Assert.Throws<ArgumentException>(() => client.Get(1, ""));
+            }
+        }
+
+        public class TheEditMethod
+        {
+            [Fact]
+            public void PatchsTheCorrectUrl()
+            {
+                var github = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(github);
+                var update = new BranchUpdate();
+
+                client.Edit("owner", "repo", "branch", update);
+
+                github.Repository.Branch.Received(1).Edit("owner", "repo", "branch", update);
+            }
+
+            [Fact]
+            public void PatchsTheCorrectUrlWithRepositoryId()
+            {
+                var github = Substitute.For<IGitHubClient>();
+                var client = new ObservableRepositoryBranchesClient(github);
+                var update = new BranchUpdate();
+
+                client.Edit(1, "branch", update);
+
+                github.Repository.Branch.Received(1).Edit(1, "branch", update);
+            }
+
+            [Fact]
+            public async Task EnsuresNonNullArguments()
+            {
+                var client = new ObservableRepositoryBranchesClient(Substitute.For<IGitHubClient>());
+                var update = new BranchUpdate();
+
+                Assert.Throws<ArgumentNullException>(() => client.Edit(null, "repo", "branch", update));
+                Assert.Throws<ArgumentNullException>(() => client.Edit("owner", null, "branch", update));
+                Assert.Throws<ArgumentNullException>(() => client.Edit("owner", "repo", null, update));
+                Assert.Throws<ArgumentNullException>(() => client.Edit("owner", "repo", "branch", null));
+
+                Assert.Throws<ArgumentNullException>(() => client.Edit(1, null, update));
+                Assert.Throws<ArgumentNullException>(() => client.Edit(1, "branch", null));
+
+                Assert.Throws<ArgumentException>(() => client.Edit("", "repo", "branch", update));
+                Assert.Throws<ArgumentException>(() => client.Edit("owner", "", "branch", update));
+                Assert.Throws<ArgumentException>(() => client.Edit("owner", "repo", "", update));
+
+                Assert.Throws<ArgumentException>(() => client.Edit(1, "", update));
+            }
+        }
+    }
+}