Making the since parameter required

Adding 💄 `Task.FromResult` to tests
octokit · Apr 6, 2015 · 68840e3 · 68840e3
1 parent ca01a2f
commit 68840e3
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 17 deletions.
diff --git a/Octokit.Tests.Integration/Clients/RepositoriesClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoriesClientTests.cs
@@ -558,7 +558,7 @@ public async Task ReturnsAllPublicRepositoriesSinceLastSeen()
         {
             var github = Helper.GetAuthenticatedClient();
 
-            var request = new PublicRepositoryRequest { Since = 32732250 };
+            var request = new PublicRepositoryRequest(32732250);
             var repositories = await github.Repository.GetAllPublic(request);
 
             Assert.NotNull(repositories);

diff --git a/Octokit.Tests.Integration/Reactive/ObservableRepositoriesClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableRepositoriesClientTests.cs
@@ -37,10 +37,7 @@ public async Task ReturnsAllPublicReposSinceLastSeen()
                 var github = Helper.GetAuthenticatedClient();
 
                 var client = new ObservableRepositoriesClient(github);
-                var request = new PublicRepositoryRequest
-                {
-                    Since = 32732250
-                };
+                var request = new PublicRepositoryRequest(32732250);
                 var repositories = await client.GetAllPublic(request).ToArray();
                 Assert.NotEmpty(repositories);
                 Assert.Equal(32732252, repositories[0].Id);

diff --git a/Octokit.Tests/Clients/RepositoriesClientTests.cs b/Octokit.Tests/Clients/RepositoriesClientTests.cs
@@ -282,7 +282,7 @@ public void RequestsTheCorrectUrl()
                 var connection = Substitute.For<IApiConnection>();
                 var client = new RepositoriesClient(connection);
 
-                client.GetAllPublic(new PublicRepositoryRequest { Since = 364 });
+                client.GetAllPublic(new PublicRepositoryRequest(364));
 
                 connection.Received()
                     .GetAll<Repository>(Arg.Is<Uri>(u => u.ToString() == "/repositories"),
@@ -295,7 +295,7 @@ public void SendsTheCorrectParameter()
                 var connection = Substitute.For<IApiConnection>();
                 var client = new RepositoriesClient(connection);
 
-                client.GetAllPublic(new PublicRepositoryRequest { Since = 364 });
+                client.GetAllPublic(new PublicRepositoryRequest(364));
 
                 connection.Received()
                     .GetAll<Repository>(Arg.Is<Uri>(u => u.ToString() == "/repositories"),

diff --git a/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs b/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs
@@ -166,17 +166,18 @@ public async Task ReturnsEveryPageOfRepositories()
                 var firstPageUrl = new Uri("/repositories", UriKind.Relative);
                 var secondPageUrl = new Uri("https://example.com/page/2");
                 var firstPageLinks = new Dictionary<string, Uri> { { "next", secondPageUrl } };
-                var firstPageResponse = new ApiResponse<List<Repository>>(
+                IApiResponse<List<Repository>> firstPageResponse = new ApiResponse<List<Repository>>(
                     CreateResponseWithApiInfo(firstPageLinks),
                     new List<Repository>
                     {
                         new Repository(364),
                         new Repository(365),
                         new Repository(366)
                     });
+
                 var thirdPageUrl = new Uri("https://example.com/page/3");
                 var secondPageLinks = new Dictionary<string, Uri> { { "next", thirdPageUrl } };
-                var secondPageResponse = new ApiResponse<List<Repository>>
+                IApiResponse<List<Repository>> secondPageResponse = new ApiResponse<List<Repository>>
                 (
                     CreateResponseWithApiInfo(secondPageLinks),
                     new List<Repository>
@@ -185,24 +186,27 @@ public async Task ReturnsEveryPageOfRepositories()
                         new Repository(368),
                         new Repository(369)
                     });
-                var lastPageResponse = new ApiResponse<List<Repository>>(
+
+                IApiResponse<List<Repository>> lastPageResponse = new ApiResponse<List<Repository>>(
                     new Response(),
                     new List<Repository>
                     {
                         new Repository(370)
                     });
+
                 var gitHubClient = Substitute.For<IGitHubClient>();
                 gitHubClient.Connection.Get<List<Repository>>(firstPageUrl,
                     Arg.Is<Dictionary<string, string>>(d => d.Count == 1
                         && d["since"] == "364"), null)
-                    .Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => firstPageResponse));
+                    .Returns(Task.FromResult(firstPageResponse));
                 gitHubClient.Connection.Get<List<Repository>>(secondPageUrl, null, null)
-                    .Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => secondPageResponse));
+                    .Returns(Task.FromResult(secondPageResponse));
                 gitHubClient.Connection.Get<List<Repository>>(thirdPageUrl, null, null)
-                    .Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => lastPageResponse));
+                    .Returns(Task.FromResult(lastPageResponse));
+
                 var repositoriesClient = new ObservableRepositoriesClient(gitHubClient);
 
-                var results = await repositoriesClient.GetAllPublic(new PublicRepositoryRequest { Since = 364 }).ToArray();
+                var results = await repositoriesClient.GetAllPublic(new PublicRepositoryRequest(364)).ToArray();
 
                 Assert.Equal(7, results.Length);
                 gitHubClient.Connection.Received(1).Get<List<Repository>>(firstPageUrl, 

diff --git a/Octokit/Clients/IRepositoriesClient.cs b/Octokit/Clients/IRepositoriesClient.cs
@@ -111,7 +111,7 @@ public interface IRepositoriesClient
 
 
         /// <summary>
-        /// Gets all public repositories since the integer ID of the last Repository that you’ve seen.
+        /// Gets all public repositories since the integer ID of the last Repository that you've seen.
         /// </summary>
         /// <remarks>
         /// See the <a href="https://developer.github.com/v3/repos/#list-all-public-repositories">API documentation</a> for more information.

diff --git a/Octokit/Clients/RepositoriesClient.cs b/Octokit/Clients/RepositoriesClient.cs
@@ -189,7 +189,7 @@ public Task<IReadOnlyList<Repository>> GetAllPublic()
         }
 
         /// <summary>
-        /// Gets all public repositories since the integer ID of the last Repository that you�ve seen.
+        /// Gets all public repositories since the integer ID of the last Repository that you've seen.
         /// </summary>
         /// <remarks>
         /// See the <a href="https://developer.github.com/v3/repos/#list-all-public-repositories">API documentation</a> for more information.

diff --git a/Octokit/Models/Request/PublicRepositoryRequest.cs b/Octokit/Models/Request/PublicRepositoryRequest.cs
@@ -11,8 +11,11 @@ namespace Octokit
     [DebuggerDisplay("{DebuggerDisplay,nq}")]
     public class PublicRepositoryRequest : RequestParameters
     {
-        public PublicRepositoryRequest()
+        public PublicRepositoryRequest(int since)
         {
+            Ensure.ArgumentNotNull(since, "since");
+
+            Since = since;
         }
 
         public long Since { get; set; }