improve handling of GetAllContentsByRef where root path is requested (#…

…2105) * add failing test for handling / as the path * workaround issue by passing in what the API expects
octokit · Feb 24, 2020 · 5223d1a · 5223d1a
1 parent 6fdd800
commit 5223d1a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/Octokit.Tests.Integration/Clients/RepositoryContentsClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryContentsClientTests.cs
@@ -222,6 +222,18 @@ public async Task GetsDirectoryContent()
                 Assert.Equal(ContentType.Dir, contents.First().Type);
             }
 
+            [IntegrationTest]
+            public async Task GetsContentNonMasterWithRootPath()
+            {
+                var github = Helper.GetAuthenticatedClient();
+
+                var contents = await github
+                    .Repository
+                    .Content
+                    .GetAllContentsByRef("octocat", "Spoon-Knife", "/", reference: "test-branch");
+                Assert.Equal(4, contents.Count);
+            }
+
             [IntegrationTest]
             public async Task GetsDirectoryContentWithRepositoryId()
             {

diff --git a/Octokit/Clients/RepositoryContentsClient.cs b/Octokit/Clients/RepositoryContentsClient.cs
@@ -107,7 +107,9 @@ public Task<IReadOnlyList<RepositoryContent>> GetAllContentsByRef(string owner,
             Ensure.ArgumentNotNullOrEmptyString(path, nameof(path));
             Ensure.ArgumentNotNullOrEmptyString(reference, nameof(reference));
 
-            var url = ApiUrls.RepositoryContent(owner, name, path, reference);
+            var url = (path == "/")
+                ? ApiUrls.RepositoryContent(owner, name, "", reference)
+                : ApiUrls.RepositoryContent(owner, name, path, reference);
 
             return ApiConnection.GetAll<RepositoryContent>(url);
         }