Trying to fix 1016

octokit · Mar 11, 2016 · 3f7e0a1 · 3f7e0a1
1 parent 0f5d7c4
commit 3f7e0a1
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 4 deletions.
diff --git a/Octokit.Tests/Clients/EventsClientTests.cs b/Octokit.Tests/Clients/EventsClientTests.cs
@@ -28,6 +28,32 @@ public void RequestsCorrectUrl()
             }
         }
 
+        public class TheGetAllIssuesForRepositoryMethod
+        {
+            [Fact]
+            public void RequestsCorrectUrl()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new EventsClient(connection);
+
+                client.GetAllIssuesForRepository("fake", "repo");
+
+                connection.Received().GetAll<Activity>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/events"));
+            }
+
+            [Fact]
+            public async Task EnsuresArgumentsNotNull()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new EventsClient(connection);
+
+                await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllIssuesForRepository(null, "name"));
+                await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllIssuesForRepository("", "name"));
+                await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllIssuesForRepository("owner", null));
+                await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllIssuesForRepository("owner", ""));
+            }
+        }
+        /*
         public class TheGetAllForRepositoryMethod
         {
             [Fact]
@@ -38,7 +64,7 @@ public void RequestsCorrectUrl()
 
                 client.GetAllForRepository("fake", "repo");
 
-                connection.Received().GetAll<Activity>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/events"));
+                connection.Received().GetAll<Activity>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/events"));
             }
 
             [Fact]
@@ -53,7 +79,7 @@ public async Task EnsuresArgumentsNotNull()
                 await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForRepository("owner", ""));
             }
         }
-
+        */
         public class TheGetAllForRepositoryNetworkMethod
         {
             [Fact]

diff --git a/Octokit/Clients/EventsClient.cs b/Octokit/Clients/EventsClient.cs
@@ -41,7 +41,7 @@ public Task<IReadOnlyList<Activity>> GetAll()
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
         /// <returns>All the <see cref="Activity"/>s for the particular repository.</returns>
-        public Task<IReadOnlyList<Activity>> GetAllForRepository(string owner, string name)
+        public Task<IReadOnlyList<Activity>> GetAllIssuesForRepository(string owner, string name)
         {
             Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
             Ensure.ArgumentNotNullOrEmptyString(name, "name");

diff --git a/Octokit/Clients/IEventsClient.cs b/Octokit/Clients/IEventsClient.cs
@@ -30,7 +30,7 @@ public interface IEventsClient
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
         /// <returns>All the <see cref="Activity"/>s for the particular repository.</returns>
-        Task<IReadOnlyList<Activity>> GetAllForRepository(string owner, string name);
+        Task<IReadOnlyList<Activity>> GetAllIssuesForRepository(string owner, string name);
 
         /// <summary>
         /// Gets all the events for a given repository network