Adds PullRequestReviewEventPayload (#1767)

* Adds PullRequestReviewEventPayload * Remove random A
octokit · Feb 25, 2018 · 3ec01bd · 3ec01bd
1 parent e430a9e
commit 3ec01bd
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 0 deletions.
diff --git a/Octokit.Tests/Clients/EventsClientTests.cs b/Octokit.Tests/Clients/EventsClientTests.cs
@@ -558,6 +558,7 @@ public async Task EnsuresNonNullArguments()
             {"IssueCommentEvent", typeof(IssueCommentPayload)},
             {"IssuesEvent", typeof(IssueEventPayload)},
             {"PullRequestEvent", typeof(PullRequestEventPayload)},
+            {"PullRequestReviewEvent", typeof(PullRequestReviewEventPayload)},
             {"PullRequestReviewCommentEvent", typeof(PullRequestCommentPayload)},
             {"PushEvent", typeof(PushEventPayload)},
             {"StatusEvent", typeof(StatusEventPayload)},
@@ -743,6 +744,43 @@ public async Task DeserializesPullRequestEventCorrectly()
             Assert.Equal("PR Title", payload.PullRequest.Title);
         }
 
+        [Fact]
+        public async Task DeserializesPullRequestReviewEventCorrectly()
+        {
+            var jsonObj = new JsonObject
+            {
+                { "type", "PullRequestReviewEvent" },
+                {
+                    "payload", new
+                    {
+                        action = "submitted",
+                        review = new {
+                            id = 2626884,
+                            body = "Looks great!",
+                            state = "approved",
+                            html_url = "https://github.com/baxterthehacker/public-repo/pull/8#pullrequestreview-2626884",
+                        },
+                        pull_request = new
+                        {
+                            title = "PR Title"
+                        }
+                    }
+                }
+            };
+
+            var client = GetTestingEventsClient(jsonObj);
+            var activities = await client.GetAll();
+            Assert.Equal(1, activities.Count);
+
+            var payload = activities.FirstOrDefault().Payload as PullRequestReviewEventPayload;
+            Assert.Equal("submitted", payload.Action);
+            Assert.Equal(2626884, payload.Review.Id);
+            Assert.Equal("Looks great!", payload.Review.Body);
+            Assert.Equal(PullRequestReviewState.Approved, payload.Review.State.Value);
+            Assert.Equal("https://github.com/baxterthehacker/public-repo/pull/8#pullrequestreview-2626884", payload.Review.HtmlUrl);
+            Assert.Equal("PR Title", payload.PullRequest.Title);
+        }
+
         [Fact]
         public async Task DeserializesPullRequestCommentEventCorrectly()
         {

diff --git a/Octokit/Http/SimpleJsonSerializer.cs b/Octokit/Http/SimpleJsonSerializer.cs
@@ -216,6 +216,8 @@ private static Type GetPayloadType(string activityType)
                         return typeof(IssueEventPayload);
                     case "PullRequestEvent":
                         return typeof(PullRequestEventPayload);
+                    case "PullRequestReviewEvent":
+                        return typeof(PullRequestReviewEventPayload);
                     case "PullRequestReviewCommentEvent":
                         return typeof(PullRequestCommentPayload);
                     case "PushEvent":

diff --git a/Octokit/Models/Response/ActivityPayloads/PullRequestReviewEventPayload.cs b/Octokit/Models/Response/ActivityPayloads/PullRequestReviewEventPayload.cs
@@ -0,0 +1,12 @@
+using System.Diagnostics;
+
+namespace Octokit
+{
+    [DebuggerDisplay("{DebuggerDisplay,nq}")]
+    public class PullRequestReviewEventPayload : ActivityPayload
+    {
+        public string Action { get; protected set; }
+        public PullRequest PullRequest { get; protected set; }
+        public PullRequestReview Review { get; protected set; }
+    }
+}