Remove obsolete items - GitHubClient

- Release - Notification - GitDatabase
octokit · Jul 16, 2016 · 2cc2ccd · 2cc2ccd
1 parent 0021269
commit 2cc2ccd
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 71 deletions.
diff --git a/Octokit.Reactive/IObservableGitHubClient.cs b/Octokit.Reactive/IObservableGitHubClient.cs
@@ -15,15 +15,9 @@ public interface IObservableGitHubClient : IApiInfoProvider
         IObservablePullRequestsClient PullRequest { get; }
         IObservableRepositoriesClient Repository { get; }
         IObservableGistsClient Gist { get; }
-        [Obsolete("Use Repository.Release instead")]
-        IObservableReleasesClient Release { get; }
         IObservableSshKeysClient SshKey { get; }
         IObservableUsersClient User { get; }
-        [Obsolete("Notifications are now available under the Activities client. This will be removed in a future update.")]
-        IObservableNotificationsClient Notification { get; }
         IObservableGitDatabaseClient Git { get; }
-        [Obsolete("Use Git instead")]
-        IObservableGitDatabaseClient GitDatabase { get; }
         IObservableSearchClient Search { get; }
         IObservableEnterpriseClient Enterprise { get; }
         IObservableMigrationClient Migration { get; }

diff --git a/Octokit.Reactive/ObservableGitHubClient.cs b/Octokit.Reactive/ObservableGitHubClient.cs
@@ -35,7 +35,6 @@ public ObservableGitHubClient(IGitHubClient gitHubClient)
             Activity = new ObservableActivitiesClient(gitHubClient);
             Issue = new ObservableIssuesClient(gitHubClient);
             Miscellaneous = new ObservableMiscellaneousClient(gitHubClient);
-            Notification = new ObservableNotificationsClient(gitHubClient);
             Oauth = new ObservableOauthClient(gitHubClient);
             Organization = new ObservableOrganizationsClient(gitHubClient);
             PullRequest = new ObservablePullRequestsClient(gitHubClient);
@@ -64,13 +63,8 @@ public IConnection Connection
         public IObservablePullRequestsClient PullRequest { get; private set; }
         public IObservableRepositoriesClient Repository { get; private set; }
         public IObservableGistsClient Gist { get; private set; }
-        [Obsolete("Use Repository.Release instead")]
-        public IObservableReleasesClient Release { get { return Repository.Release; } }
         public IObservableSshKeysClient SshKey { get; private set; }
         public IObservableUsersClient User { get; private set; }
-        public IObservableNotificationsClient Notification { get; private set; }
-        [Obsolete("Use Git instead")]
-        public IObservableGitDatabaseClient GitDatabase { get { return Git; } }
         public IObservableGitDatabaseClient Git { get; private set; }
         public IObservableSearchClient Search { get; private set; }
         public IObservableEnterpriseClient Enterprise { get; private set; }

diff --git a/Octokit/GitHubClient.cs b/Octokit/GitHubClient.cs
@@ -91,7 +91,6 @@ public GitHubClient(IConnection connection)
             Issue = new IssuesClient(apiConnection);
             Migration = new MigrationClient(apiConnection);
             Miscellaneous = new MiscellaneousClient(connection);
-            Notification = new NotificationsClient(apiConnection);
             Oauth = new OauthClient(connection);
             Organization = new OrganizationsClient(apiConnection);
             PullRequest = new PullRequestsClient(apiConnection);
@@ -226,20 +225,9 @@ public Uri BaseAddress
         public IGistsClient Gist { get; private set; }
 
         /// <summary>
-        /// Access GitHub's Releases API.
-        /// </summary>
-        /// <remarks>
-        /// Refer to the API documentation for more information: https://developer.github.com/v3/repos/releases/
-        /// </remarks>
-        [Obsolete("Use Repository.Release instead")]
-        public IReleasesClient Release
-        {
-            get { return Repository.Release; }
-        }
 
         // TODO: this should be under Users to align with the API docs
         // TODO: this should be named PublicKeys to align with the API docs
-        /// <summary>
         /// Access GitHub's Public Keys API.
         /// </summary>
         /// <remarks>
@@ -255,24 +243,6 @@ public IReleasesClient Release
         /// </remarks>
         public IUsersClient User { get; private set; }
 
-        // TODO: this should be under Activities to align with the API docs
-        /// <summary>
-        /// Access GitHub's Notifications API.
-        /// </summary>
-        /// <remarks>
-        /// Refer to the API documentation for more information: https://developer.github.com/v3/activity/notifications/
-        /// </remarks>
-        public INotificationsClient Notification { get; private set; }
-
-        /// <summary>
-        /// Access GitHub's Git Data API.
-        /// </summary>
-        /// <remarks>
-        /// Refer to the API documentation for more information: https://developer.github.com/v3/git/
-        /// </remarks>
-        [Obsolete("Use Git instead")]
-        public IGitDatabaseClient GitDatabase { get { return Git; } }
-
         /// <summary>
         /// Access GitHub's Git Data API.
         /// </summary>

diff --git a/Octokit/IGitHubClient.cs b/Octokit/IGitHubClient.cs
@@ -92,16 +92,6 @@ public interface IGitHubClient : IApiInfoProvider
         /// </remarks>
         IGistsClient Gist { get; }
 
-        // TODO: this should be under Repositories to align with the API docs
-        /// <summary>
-        /// Access GitHub's Releases API.
-        /// </summary>
-        /// <remarks>
-        /// Refer to the API documentation for more information: https://developer.github.com/v3/repos/releases/
-        /// </remarks>
-        [Obsolete("Use Repository.Release instead")]
-        IReleasesClient Release { get; }
-
         // TODO: this should be under Users to align with the API docs
         // TODO: this should be named PublicKeys to align with the API docs
         /// <summary>
@@ -120,25 +110,6 @@ public interface IGitHubClient : IApiInfoProvider
         /// </remarks>
         IUsersClient User { get; }
 
-        // TODO: this should be under Activities to align with the API docs
-        /// <summary>
-        /// Access GitHub's Notifications API.
-        /// </summary>
-        /// <remarks>
-        /// Refer to the API documentation for more information: https://developer.github.com/v3/activity/notifications/
-        /// </remarks>
-        [Obsolete("Notifications are now available under the Activities client. This will be removed in a future update.")]
-        INotificationsClient Notification { get; }
-
-        /// <summary>
-        /// Access GitHub's Git Data API.
-        /// </summary>
-        /// <remarks>
-        /// Refer to the API documentation for more information: https://developer.github.com/v3/git/
-        /// </remarks>
-        [Obsolete("Use Git instead")]
-        IGitDatabaseClient GitDatabase { get; }
-
         /// <summary>
         /// Access GitHub's Git Data API.
         /// </summary>