Skip to content

Commit

Permalink
removes obsolete RepositoryTrafficClient.GetReferrers (replaced with …
Browse files Browse the repository at this point in the history 
…GetAllReferrers)

removes obsolete RepositoryTrafficClient.GetPaths (replaced with GetAllPaths)
  • Loading branch information
@ryangribble
ryangribble committed Mar 6, 2018
1 parent a2a5e2c commit 2a91a41
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 166 deletions.
34 changes: 0 additions & 34 deletions Octokit.Reactive/Clients/IObservableRepositoryTrafficClient.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,6 @@ namespace Octokit.Reactive
/// </remarks>
public interface IObservableRepositoryTrafficClient
{
/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
IObservable<RepositoryTrafficReferrer> GetReferrers(string owner, string name);

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
IObservable<RepositoryTrafficReferrer> GetReferrers(long repositoryId);

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
Expand All @@ -42,23 +25,6 @@ public interface IObservableRepositoryTrafficClient
/// <param name="repositoryId">The owner of the repository</param>
IObservable<RepositoryTrafficReferrer> GetAllReferrers(long repositoryId);

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
IObservable<RepositoryTrafficPath> GetPaths(string owner, string name);

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
IObservable<RepositoryTrafficPath> GetPaths(long repositoryId);

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
Expand Down
46 changes: 0 additions & 46 deletions Octokit.Reactive/Clients/ObservableRepositoryTrafficClient.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,29 +15,6 @@ public ObservableRepositoryTrafficClient(IGitHubClient client)
_client = client.Repository.Traffic;
}

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
public IObservable<RepositoryTrafficPath> GetPaths(long repositoryId)
{
return GetAllPaths(repositoryId);
}

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
public IObservable<RepositoryTrafficPath> GetPaths(string owner, string name)
{
return GetAllPaths(owner, name);
}

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
Expand All @@ -62,29 +39,6 @@ public IObservable<RepositoryTrafficPath> GetAllPaths(string owner, string name)
return _client.GetAllPaths(owner, name).ToObservable().SelectMany(x => x);
}

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
public IObservable<RepositoryTrafficReferrer> GetReferrers(long repositoryId)
{
return GetAllReferrers(repositoryId);
}

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
public IObservable<RepositoryTrafficReferrer> GetReferrers(string owner, string name)
{
return GetAllReferrers(owner, name);
}

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
Expand Down
40 changes: 0 additions & 40 deletions Octokit/Clients/IRepositoryTrafficClient.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,29 +12,6 @@ namespace Octokit
/// </remarks>
public interface IRepositoryTrafficClient
{
/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
Task<IReadOnlyList<RepositoryTrafficReferrer>> GetReferrers(string owner, string name);

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
Task<IReadOnlyList<RepositoryTrafficReferrer>> GetReferrers(long repositoryId);

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[ExcludeFromPaginationApiOptionsConventionTest("Pagination not supported by GitHub API (tested 29/08/2017)")]
Task<IReadOnlyList<RepositoryTrafficReferrer>> GetAllReferrers(string owner, string name);

Expand All @@ -46,23 +23,6 @@ public interface IRepositoryTrafficClient
[ExcludeFromPaginationApiOptionsConventionTest("Pagination not supported by GitHub API (tested 29/08/2017)")]
Task<IReadOnlyList<RepositoryTrafficReferrer>> GetAllReferrers(long repositoryId);

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
Task<IReadOnlyList<RepositoryTrafficPath>> GetPaths(string owner, string name);

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
Task<IReadOnlyList<RepositoryTrafficPath>> GetPaths(long repositoryId);

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
Expand Down
46 changes: 0 additions & 46 deletions Octokit/Clients/RepositoryTrafficClient.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,29 +10,6 @@ public RepositoryTrafficClient(IApiConnection apiConnection) : base(apiConnectio
{
}

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
public Task<IReadOnlyList<RepositoryTrafficPath>> GetPaths(long repositoryId)
{
return GetAllPaths(repositoryId);
}

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
public Task<IReadOnlyList<RepositoryTrafficPath>> GetPaths(string owner, string name)
{
return GetAllPaths(owner, name);
}

/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
Expand All @@ -57,29 +34,6 @@ public Task<IReadOnlyList<RepositoryTrafficPath>> GetAllPaths(string owner, stri
return ApiConnection.GetAll<RepositoryTrafficPath>(ApiUrls.RepositoryTrafficPaths(owner, name), AcceptHeaders.RepositoryTrafficApiPreview);
}

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
public Task<IReadOnlyList<RepositoryTrafficReferrer>> GetReferrers(long repositoryId)
{
return GetAllReferrers(repositoryId);
}

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
public Task<IReadOnlyList<RepositoryTrafficReferrer>> GetReferrers(string owner, string name)
{
return GetAllReferrers(owner, name);
}

/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
Expand Down

0 comments on commit 2a91a41

Please sign in to comment.