Skip to content

Commit

Permalink
Add Reactive Pull Request Review Request API.
Browse files Browse the repository at this point in the history
  • Loading branch information
gdziadkiewicz committed Apr 20, 2017
1 parent 1e3512f commit 2624676
Show file tree
Hide file tree
Showing 8 changed files with 111 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
using System;
using System.Collections.Generic;
using System.Reactive;
using System.Threading.Tasks;

namespace Octokit.Reactive
{
/// <summary>
/// A client for GitHub's Pull Request Review Requests API.
/// </summary>
/// <remarks>
/// See the <a href="https://developer.github.com/v3/pulls/review_requests/">Review Requests API documentation</a> for more information.
/// </remarks>
public interface IObservablePullRequestReviewRequestsClient
{
/// <summary>
/// Gets review requests for a specified pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#list-review-requests</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<User> GetAll(string owner, string name, int number);

/// <summary>
/// Creates review requests on a pull request for specified users.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#create-a-review-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="users">List of logins of user will be requested for review</param>
IObservable<PullRequestReviewRequestCreate> Create(string owner, string name, int number, PullRequestReviewRequest users);

/// <summary>
/// Deletes review request for given users on a pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#delete-a-review-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="users">List of logins of users that will be not longer requested for review</param>
IObservable<Unit> Delete(string owner, string name, int number, PullRequestReviewRequest users);
}
}
5 changes: 5 additions & 0 deletions Octokit.Reactive/Clients/IObservablePullRequestsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ public interface IObservablePullRequestsClient
/// </summary>
IObservablePullRequestReviewCommentsClient ReviewComment { get; }

/// <summary>
/// Client for managing review requests.
/// </summary>
IObservablePullRequestReviewRequestsClient ReviewRequests { get; }

/// <summary>
/// Gets a single Pull Request by number.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
using System;
using System.Reactive;
using System.Reactive.Threading.Tasks;
using Octokit.Reactive.Internal;

namespace Octokit.Reactive
{
public class ObservablePullRequestReviewRequestsClient : IObservablePullRequestReviewRequestsClient
{
readonly IPullRequestReviewRequestsClient _client;
readonly IConnection _connection;

public ObservablePullRequestReviewRequestsClient(IGitHubClient client)
{
Ensure.ArgumentNotNull(client, "client");

_client = client.PullRequest.ReviewRequests;
_connection = client.Connection;
}

public IObservable<User> GetAll(string owner, string name, int number)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");

return _connection.GetAndFlattenAllPages<User>(ApiUrls.PullRequestReviewRequests(owner, name, number), null, AcceptHeaders.PullRequestReviewsApiPreview);
}

public IObservable<PullRequestReviewRequestCreate> Create(string owner, string name, int number, PullRequestReviewRequest users)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(users, "users");

return _client.Create(owner, name, number, users).ToObservable();
}

public IObservable<Unit> Delete(string owner, string name, int number, PullRequestReviewRequest users)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(users, "users");

return _client.Delete(owner, name, number, users).ToObservable();
}
}
}
6 changes: 6 additions & 0 deletions Octokit.Reactive/Clients/ObservablePullRequestsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,19 @@ public class ObservablePullRequestsClient : IObservablePullRequestsClient
/// </summary>
public IObservablePullRequestReviewCommentsClient ReviewComment { get; private set; }

/// <summary>
/// Client for managing review requests.
/// </summary>
public IObservablePullRequestReviewRequestsClient ReviewRequests { get; private set; }

public ObservablePullRequestsClient(IGitHubClient client)
{
Ensure.ArgumentNotNull(client, "client");

_client = client.Repository.PullRequest;
_connection = client.Connection;
ReviewComment = new ObservablePullRequestReviewCommentsClient(client);
ReviewRequests = new ObservablePullRequestReviewRequestsClient(client);
}

/// <summary>
Expand Down
2 changes: 2 additions & 0 deletions Octokit.Reactive/Octokit.Reactive-Mono.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@
<Compile Include="Clients\ObservableRepositoryBranchesClient.cs" />
<Compile Include="Clients\IObservableRepositoryTrafficClient.cs" />
<Compile Include="Clients\ObservableRepositoryTrafficClient.cs" />
<Compile Include="Clients\IObservablePullRequestReviewRequestsClient.cs" />
<Compile Include="Clients\ObservablePullRequestReviewRequestsClient.cs" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions Octokit.Reactive/Octokit.Reactive-MonoAndroid.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@
<Compile Include="Clients\ObservableRepositoryBranchesClient.cs" />
<Compile Include="Clients\IObservableRepositoryTrafficClient.cs" />
<Compile Include="Clients\ObservableRepositoryTrafficClient.cs" />
<Compile Include="Clients\IObservablePullRequestReviewRequestsClient.cs" />
<Compile Include="Clients\ObservablePullRequestReviewRequestsClient.cs" />
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath)\Novell\Novell.MonoDroid.CSharp.targets" />
<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions Octokit.Reactive/Octokit.Reactive-Monotouch.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@
<Compile Include="Clients\ObservableRepositoryBranchesClient.cs" />
<Compile Include="Clients\IObservableRepositoryTrafficClient.cs" />
<Compile Include="Clients\ObservableRepositoryTrafficClient.cs" />
<Compile Include="Clients\IObservablePullRequestReviewRequestsClient.cs" />
<Compile Include="Clients\ObservablePullRequestReviewRequestsClient.cs" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions Octokit.Reactive/Octokit.Reactive.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@
<Compile Include="Clients\IObservableMigrationClient.cs" />
<Compile Include="Clients\IObservableOauthClient.cs" />
<Compile Include="Clients\IObservablePullRequestReviewCommentReactionsClient.cs" />
<Compile Include="Clients\IObservablePullRequestReviewRequestsClient.cs" />
<Compile Include="Clients\IObservableRepositoryTrafficClient.cs" />
<Compile Include="Clients\ObservablePullRequestReviewRequestsClient.cs" />
<Compile Include="Clients\ObservableRepositoryBranchesClient.cs" />
<Compile Include="Clients\IObservableRepositoryBranchesClient.cs" />
<Compile Include="Clients\IObservableRepositoryCommitsClients.cs" />
Expand Down

0 comments on commit 2624676

Please sign in to comment.