Release v0.32 - App-stravaganza! (#1864)

* generate release notes * fix failing test * fix repository hooks tests (seems like agilezen causes a problem) * run FormatCode build task * update release notes to include issue labels fix * fix release date
octokit · Sep 9, 2018 · 050b85b · 050b85b
1 parent cee6635
commit 050b85b
Show file tree

Hide file tree

Showing 7 changed files with 45 additions and 12 deletions.
diff --git a/Octokit.Tests.Integration/Clients/GitHubAppsClientTests.cs b/Octokit.Tests.Integration/Clients/GitHubAppsClientTests.cs
@@ -116,7 +116,7 @@ public TheGetAllInstallationsForCurrentUserMethod()
                 _github = null;
             }
 
-            [GitHubAppsTest(Skip ="Not possible to authenticate with User to Server auth")]
+            [GitHubAppsTest(Skip = "Not possible to authenticate with User to Server auth")]
             public async Task GetsAllInstallationsForCurrentUser()
             {
                 var result = await _github.GitHubApps.GetAllInstallationsForCurrentUser();
@@ -224,7 +224,7 @@ public TheGetUserInstallationForCurrentMethod()
             public async Task GetsUserInstallations()
             {
                 var result = await _github.GitHubApps.GetUserInstallationForCurrent(Helper.UserName);
-                
+
                 Assert.NotNull(result);
             }
         }

diff --git a/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs
@@ -582,7 +582,7 @@ public async Task CanSpecifyDirectionOfSort()
         var pullRequests = await _fixture.GetAllForRepository(Helper.UserName, _context.RepositoryName, new PullRequestRequest { SortDirection = SortDirection.Ascending });
         Assert.Equal(pullRequest.Title, pullRequests[0].Title);
 
-        var pullRequestsDescending = await _fixture.GetAllForRepository(Helper.UserName, _context.RepositoryName, new PullRequestRequest());
+        var pullRequestsDescending = await _fixture.GetAllForRepository(Helper.UserName, _context.RepositoryName, new PullRequestRequest { SortDirection = SortDirection.Descending });
         Assert.Equal(anotherPullRequest.Title, pullRequestsDescending[0].Title);
     }
 

diff --git a/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs
@@ -83,9 +83,9 @@ public async Task ReturnsCorrectCountOfHooksWithStart()
 
                 var options = new ApiOptions
                 {
-                    PageSize = 2,
+                    PageSize = 3,
                     PageCount = 1,
-                    StartPage = 3
+                    StartPage = 2
                 };
 
                 var hooks = await github.Repository.Hooks.GetAll(_fixture.RepositoryOwner, _fixture.RepositoryName, options);
@@ -100,9 +100,9 @@ public async Task ReturnsCorrectCountOfHooksWithStartWithRepositoryId()
 
                 var options = new ApiOptions
                 {
-                    PageSize = 2,
+                    PageSize = 3,
                     PageCount = 1,
-                    StartPage = 3
+                    StartPage = 2
                 };
 
                 var hooks = await github.Repository.Hooks.GetAll(_fixture.RepositoryId, options);

diff --git a/Octokit.Tests.Integration/Reactive/ObservableRepositoryHooksClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableRepositoryHooksClientTests.cs
@@ -60,9 +60,9 @@ public async Task ReturnsCorrectCountOfHooksWithStart()
 
                 var options = new ApiOptions
                 {
-                    PageSize = 2,
+                    PageSize = 3,
                     PageCount = 1,
-                    StartPage = 3
+                    StartPage = 2
                 };
 
                 var hooks = await client.GetAll(_fixture.RepositoryOwner, _fixture.RepositoryName, options).ToList();

diff --git a/Octokit.Tests.Integration/fixtures/RepositoriesHooksFixture.cs b/Octokit.Tests.Integration/fixtures/RepositoriesHooksFixture.cs
@@ -19,8 +19,7 @@ public RepositoriesHooksFixture()
                 CreateHook(_github, _repository, "awscodedeploy", "deployment"),
                 CreateHook(_github, _repository, "awsopsworks", "push"),
                 CreateHook(_github, _repository, "activecollab", "push"),
-                CreateHook(_github, _repository, "acunote", "push"),
-                CreateHook(_github, _repository, "agilezen", "push")
+                CreateHook(_github, _repository, "acunote", "push")
             };
             _hook = _hooks[0];
         }

diff --git a/Octokit.Tests/Reactive/ObservableGitHubAppsClientTests.cs b/Octokit.Tests/Reactive/ObservableGitHubAppsClientTests.cs
@@ -57,7 +57,7 @@ public void GetsFromCorrectUrl()
             {
                 var gitHubClient = Substitute.For<IGitHubClient>();
                 var client = new ObservableGitHubAppsClient(gitHubClient);
-                
+
                 client.GetCurrent();
 
                 gitHubClient.GitHubApps.Received().GetCurrent();

diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -1,3 +1,37 @@
+### New in 0.32.0 (released 09/09/2018)
+
+## Advisories and Breaking Changes
+
+- Due to upstream breaking changes in the CheckRuns API, using check runs against github.com will require using the new/renamed fields on `CheckRunAnnotation` response and `NewCheckRunAnnotation` request models.  However the old fields are maintained in octokit.net (marked as deprecated) to continue supporting GitHub Enterprise 2.14, which will not receive these changes.  Users of GHE 2.14 should use the old fields, whilst users of github.com should update to use the new fields
+
+## Release Notes
+
+### Milestone: GitHub Apps
+
+**Features/Enhancements**
+
+- Adjust GitHub App Installation Access Token route in line with [announced API changes](https://developer.github.com/changes/2018-08-16-renaming-and-deprecation-of-github-app-installation-access-token-route/) - [#1860](https://github.com/octokit/octokit.net/pull/1860) via [@ryangribble](https://github.com/ryangribble)
+- Implement additional endpoints for GitHub Apps to find installations for a given organization, repository or user - [#1854](https://github.com/octokit/octokit.net/pull/1854) via [@StanleyGoldman](https://github.com/StanleyGoldman), [@ryangribble](https://github.com/ryangribble)
+- Implement GitHub Apps Installation API to allow listing all repositories a GitHub App Installation or GitHub App authenticated user has access to - [#1854](https://github.com/octokit/octokit.net/pull/1854) via [@StanleyGoldman](https://github.com/StanleyGoldman), [@ryangribble](https://github.com/ryangribble)
+- Implement new/changed fields on `CheckRunAnnotation` response and `NewCheckRunAnnotation` request models - replace `Filename` with `Path`, `WarningLevel` with `AnnotationLevel` and add `StartColumn` and `EndColumn` - [#1857](https://github.com/octokit/octokit.net/pull/1857) via [@ryangribble](https://github.com/ryangribble)
+- Add new method `CheckSuitesClient.Rerequest()` and mark the old `CheckSuitesClient.Request()` method as deprecated (this will no longer function on github.com but will continue to be supported on GitHub Enterprise 2.14) - [#1857](https://github.com/octokit/octokit.net/pull/1857) via [@ryangribble](https://github.com/ryangribble)
+
+**Fixes**
+
+- Adjust `StartedAt` and `Status` fields of `NewCheckRun` and `CheckRunUpdate` requests, to allow `null` values, avoiding resetting these to default values when not specified - [#1852](https://github.com/octokit/octokit.net/pull/1852) via [@Cyberboss](https://github.com/Cyberboss), [@ryangribble](https://github.com/ryangribble)
+
+**Documentation Updates**
+
+- Fixed code samples in GitHub Apps sample docs to use the correct sub client property name - [#1853](https://github.com/octokit/octokit.net/pull/1853) via [@d-a-s](https://github.com/d-a-s)
+
+
+### Milestone: None
+
+**Fixes**
+
+- `IssueLabelsClient.RemoveFromIssue()` no longer fails with a HTTP 400 "Bad Request" error from the GitHub Api - [#1868](https://github.com/octokit/octokit.net/pull/1868) via [@ryangribble](https://github.com/ryangribble)
+
+
 ### New in 0.31.0 (released 21/07/2018)
 
 ## Advisories and Breaking Changes