[BUG]: Octokit breaks Deno tests

[ThisGuyCodes]

What happened?

When I run deno test with tests that use Octokit, I get a "Module not found" error. Running non-tests works fine.

Here's a gist that will reproduce this: https://gist.github.com/ThisGuyCodes/3d98652574ad726754fa7b5069367553

But really, this is the code (main_test.ts):

import { App } from "octokit";

Deno.test({
  name: "App",
  fn() {
    new App({
      appId: "1234567890",
      privateKey: "1234567890",
    });
  },
});

and here's the deno.json:

{
  "imports": {
    "octokit": "https://esm.sh/[email protected]?dts"
  }
}

Versions

Octokit.js v4.0.2
Deno v2.0.6

Relevant log output

$ deno test
error: Module not found "https://esm.sh/v135/@octokit/[email protected]/dist-types/web.d.ts".
    at https://esm.sh/v135/[email protected]/dist-types/app.d.ts:1:35
$

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

That file simply does not exist at all. It's an error in the package.json

This will be fixed when octokit/app.js#583 is merged.

[ThisGuyCodes]

thank you @wolfy1339! I was going crazy trying to figure this out 😓

[ThisGuyCodes]

ok, this feels superfluous, but the process linked by the bot says "Critical" includes:

Broken or non functioning SDK that has been published - Any stop work scenarios for users (where rollback is not possible)

If it's purported that esm.sh / Deno is "supported" (which, I mean it's in the readme for how to use it), I feel this counts as "non functional". There's an argument it's more like "broken features" from the "High" priority, but only if you argue "being able to use the SDK at all is a feature".