Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: Improved CI #326

Merged
merged 5 commits into from
Oct 7, 2024
Merged

GitHub: Improved CI #326

merged 5 commits into from
Oct 7, 2024

Conversation

0x5bfa
Copy link
Contributor

@0x5bfa 0x5bfa commented Sep 19, 2024

Before the change?

  • Deleted unnecessary CIs
    • add_to_octokit_project.yml
    • generate-schema.yml
    • integration-tests.yml
  • Improved the main CI (including fixes)
  • Merged auto add to the project and auto comment Actions

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • No

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Lamparter
Lamparter suggested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few suggestions 😄

@0x5bfa while you're at it, would you mind changing the PR title to "GitHub: Improve CI" or something like that?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/generate-schema.yml Show resolved Hide resolved
.github/workflows/generate-schema.yml Show resolved Hide resolved
.github/workflows/auto-response.yml Outdated Show resolved Hide resolved
.github/workflows/auto-response.yml Outdated Show resolved Hide resolved
.github/workflows/auto-response.yml Outdated Show resolved Hide resolved
.github/workflows/auto-response.yml Outdated Show resolved Hide resolved
@0x5bfa 0x5bfa changed the title Improved a few of CI GitHub: Improved CI Sep 20, 2024
nickfloyd
nickfloyd requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey y'all,

Thanks again for the improvements. I have a few comments for clarity. Please let me know if you have any questions.

.github/workflows/auto-response.yml Outdated Show resolved Hide resolved
.github/workflows/auto-response.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/generate-schema.yml Show resolved Hide resolved
.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
@Lamparter
Copy link
Contributor

@0x5bfa FYI
https://github.com/RiversideValley/Octokit-CommunityHealth

@nickfloyd
Copy link
Contributor

The ci.yml changes look great... the only thing remaining is to rollback the changes made to immediate-response / auto-response.

@0x5bfa
Copy link
Contributor Author

0x5bfa commented Sep 28, 2024 •
edited
Loading

All clear, up for merge.
We'll make changes in .github repo shortly.

Btw what's configure-integration-tests.ps1 for?

@0x5bfa 0x5bfa mentioned this pull request Sep 28, 2024
Open
@nickfloyd nickfloyd merged commit c4d75f1 into octokit:main Oct 7, 2024
3 checks passed
@nickfloyd
Copy link
Contributor

Btw what's configure-integration-tests.ps1 for?

Great question. I couldn't tell you with 100% certainty but from what I remember this was a sort of primer to establish a local environment for running tests.

Candidly, I feel like a README on running tests would serve us all in a much better way, platform independent, tooling independent, and all that...

@Lamparter Lamparter deleted the 5bfa/ci branch October 7, 2024 20:43
@Lamparter
Copy link
Contributor

Lamparter commented Oct 7, 2024 •
edited
Loading

The CI badge in the README is broken 😅
Posting a quick fix now #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lamparter Lamparter Lamparter requested changes

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x5bfa @Lamparter @nickfloyd