Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): GitHub Enterprise Server usage #226

Merged

Conversation

leandredasilva
Copy link
Contributor

The example provided to set an enterprise server URL doesn't work,
It works with Octokit core defaults (tested) so I suggest this change in the readme.

The example provided to set an enterprise server URL doesn't work, 
It works with Octokit core defaults (tested).
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the pull request, that must have been a copy & paste fail.

Can you please revert the 2nd change though?

README.md Outdated Show resolved Hide resolved
Revert unwanted changes.
@gr2m gr2m added Type: Bug Something isn't working as documented documentation labels Apr 20, 2021
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@gr2m gr2m changed the title Fix example for GitHub Enterprise server URL docs(README): GitHub Enterprise Server usage Apr 20, 2021
@gr2m gr2m merged commit 4da7c4f into octokit:master Apr 20, 2021
@leandredasilva leandredasilva deleted the fix-readme-for-enterprise-server-url branch June 4, 2021 14:21
@github-actions
Copy link

github-actions bot commented Jun 5, 2021

🎉 This PR is included in version 3.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants