Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites the ca tests to use the dispatcher and custom fetch #585

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

nickfloyd
Copy link
Contributor

@nickfloyd nickfloyd commented Jul 10, 2023

RE: #563

Now that we have introduced the changes for removing agent from octokit.request we needed to rework some tests to use the new patterns.


Behavior

Before the change?

  • The CA tests were skipped

After the change?

  • They have now been rewritten to use a dispatcher and custom fetch

@nickfloyd nickfloyd added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 10, 2023
server = createServer(
{
key: readFileSync(resolve(__dirname, "./localhost.key")),
cert: readFileSync(resolve(__dirname, "./localhost.crt")),
requestCert: true,
rejectUnauthorized: false,

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool to see it working! I think local certificates wasn't supported by the native fetch for a while, glad to see it's possible now

@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants