-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle zone type based on prefix zone name #50
base: main
Are you sure you want to change the base?
feat: handle zone type based on prefix zone name #50
Conversation
Signed-off-by: Thierry Ferreira <[email protected]>
If I understand the need here i believe this would more commonly be done as a A single source (YamlProvider) that has both as targets would work if all the zones are shared across both. If there are separately public and private zones then two separate sources would work. If there's some private, some public, and some both, then 3 providers. Pretty much any setup you can imagine would be possible. |
In case you have 2 DNS zones for DNS domain example.net, one private and one public on Google cloud, if you have the following naming convention :
I propose to use a field "zone_prefix" to indicate if it's a private or public DNS zone type: It's a workaround for this issue: #23 |
There is a wider issue with private domains - as you can have multiple VPCs each with their own private zone. |
Without knowing specifics it's hard to say exactly what will work, but my first thought is that there'd be 1 config file per VPC with the setup for that VPC configured and |
That 1-1 relationship might also cause some issues as you can also have a private zone in use by multiple VPCs. With the Google provider, we may be backed into a corner of having to refer to the zone name as it is the only thing that seems to be unique. The Azure OctoDNS provider went down the route of providing a separate private provider - is that what we may have to do here? |
Again without knowing all the details I can't really spell out an example, but that's where having multiple configs point to a directory of shared zone data can come into play. If the records are identical, but in a slightly different zone (e.g. with the vpc name in it) a custom YamlProvider that takes
IIRC Azure private DNS has some differences from public and thus required seperate providers. I think some of the other providers just have private/public params, or at they very least there are some with I'm not familar enough with gcloud dns to know what the difference between a private and public dns zone are API-wise and thus know off-hand what direction it needs to take. |
As Google cloud python library on managedzone doesn't have zone type attribute, if we want to handle public / private zones, we could use the zone name if we prefix them with private/public or other as a workaround.