-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create .gitpod.Dockerfile and .gitpod.yml #395
Conversation
Marking this PR as a draft until we get feedback from the creator of the repository where I copy/pasted stuff from... 😄 |
Hi @HonkingGoose, yes go for it and use the code anywhere you like. I'm glad it's helpful and solves that challenge for others 😄. |
@mikenikles To be extra clear, do you want those two files to use the Octoclairvoyant BSD 2 clause license, or the MIT license? 😉 |
I don't have enough knowledge about the various licenses to make an informed comment. As long as me and anyone else can continue to freely use and modify my initial files in my repo, I'm ok if you copy & paste the content and license it under BSD-2. |
I don't know much about these licenses as well. But I figure it's better to ask ahead of time about licensing, before copy/pasting stuff.. 😄 If we want to be sure we can contribute any changes we make back to you, we should probably keep the original MIT license for these files... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a bit messy having the license text in a comment, but I'm not sure how else to add this work to our project in a legal manner.
Changes
Tell Prettier to ignore theedit: turns out Prettier doesn't even attempt to format Dockerfiles, it's not one of their supported languages....gitpod.Dockerfile
Context
The
.gitpod.Dockerfile
is a real Dockerfile, just with a different name. We need to install some dependencies to make Cypress work with Gitpod.Fixes #379.
License warning
The Gitpod configuration file and the Gitpod "Dockerfile" are based on files from https://github.com/mikenikles/cypress-on-gitpod repository, that uses the MIT license. Not sure if we can mix-and-match with our BSD-2-clause license. To be on the safe side, I've put a license comment in those two files, with a link to the source repository where I basically copy/pasted the code, and then made some customization for our own situation.
Question for maintainer/author of
mikenikles/cypress-on-gitpod
Hi @mikenikles, as you can see I'm using 2 files of your repository
cypress-on-gitpod
as a base for our Gitpod configuration.I also grabbed the changes that are in a pending PR: https://github.com/mikenikles/cypress-on-gitpod/pull/3
Are you okay for me to use these two files and customize them? By the way, thank you very much for figuring out how to run Cypress on Gitpod, I would not have got that working myself! 😄
If you want we can keep the MIT license warning in these two files.
Let me know what you like best! 😉