Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageResizer fixes #5379

Merged
merged 3 commits into from
Dec 8, 2020
Merged

ImageResizer fixes #5379

merged 3 commits into from
Dec 8, 2020

Conversation

mjauvin
Copy link
Contributor

@mjauvin mjauvin commented Dec 3, 2020 •
edited
Loading

  • missing "string" in width/height accepted params types
  • fix config key names (only local disk was being used)

@LukeTowers LukeTowers added this to the v1.1.2 milestone Dec 8, 2020
@LukeTowers LukeTowers merged commit b090d0d into octobercms:develop Dec 8, 2020
@mjauvin mjauvin deleted the filter-get-url-docblock branch December 8, 2020 19:29
@mjauvin mjauvin mentioned this pull request Dec 15, 2020
Closed
@mjauvin mjauvin changed the title Match constructor params docblock ImageResizer fixes Dec 15, 2020
@LukeTowers
Copy link
Contributor

Also fixes #5405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers Awaiting requested review from LukeTowers

Assignees
No one assigned
Labels
Status: Completed Type: Maintenance
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mjauvin @LukeTowers @bennothommo