Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement core support for | resize(width, height, options) filter #5231

Merged
merged 36 commits into from
Aug 22, 2020
Merged

Implement core support for | resize(width, height, options) filter #5231

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
c3fbc13
wip dump on image resizing functionality
LukeTowers Aug 3, 2020
f56d1ee
Further work on the new resizing functionality
LukeTowers Aug 7, 2020
cdc45b0
Further WIP on resizer implementation, moving towards resizer object …
LukeTowers Aug 7, 2020
7b9408e
More WIP, moved logic in the appropriate locations
LukeTowers Aug 8, 2020
263ae87
More WIP on image resizer
LukeTowers Aug 9, 2020
6926908
required code from last commit
LukeTowers Aug 9, 2020
a992fb4
Support the resized URL as a route param instead of GET variable, ini…
LukeTowers Aug 9, 2020
b4dd255
Merge branch 'develop' into wip/image-resizing
LukeTowers Aug 9, 2020
9cb8a08
Finished implementing support for retrieving thumb URLs from FileMode…
LukeTowers Aug 13, 2020
17664dc
Reorganized the ImageResizer class
LukeTowers Aug 13, 2020
f54b167
Merge branch 'develop' into wip/image-resizing
LukeTowers Aug 13, 2020
04de6ef
Play nicer with tests
LukeTowers Aug 13, 2020
2351f21
Implemented resizing logic for File models, fixed bugs
LukeTowers Aug 14, 2020
064fc1f
Merge branch 'develop' into wip/image-resizing
bennothommo Aug 14, 2020
d52893d
Will need to use PluginTestCase for FileModel to be supported
bennothommo Aug 14, 2020
288918a
Finished initial implementation of resizer for all supported input im…
LukeTowers Aug 14, 2020
75e6633
Merge branch 'wip/image-resizing' of github.com:octobercms/october in…
LukeTowers Aug 14, 2020
545b899
Removed unnecessary design doc
LukeTowers Aug 14, 2020
ca386e2
tweak to default config for resized disk
LukeTowers Aug 14, 2020
f346312
Minor improvements
LukeTowers Aug 15, 2020
c25e41d
Remove unneeded use case
bennothommo Aug 17, 2020
096f5fd
Initial unit tests - WIP
bennothommo Aug 17, 2020
1fd9529
Add 'auto' height and width options
bennothommo Aug 17, 2020
0020809
Additional work on tests, should pass now
bennothommo Aug 17, 2020
aeae1bd
Remove trailing commas in commands
bennothommo Aug 17, 2020
5b5a15b
Ensure theme cache is rest to the "test" theme for ImageResizer
bennothommo Aug 17, 2020
05731b1
Fix bug
LukeTowers Aug 18, 2020
1f5350b
Test falsey width/height values
bennothommo Aug 19, 2020
b795ba6
Add URL sources tests
bennothommo Aug 19, 2020
3f58951
wip on imageWidth / imageHeight filter
LukeTowers Aug 19, 2020
444069d
Finished implement imageWidth & imageHeight filters
LukeTowers Aug 21, 2020
1e6573c
Cleaned up inline docs for ImageResizer, fixed tests
LukeTowers Aug 21, 2020
825075a
Fix support for Windows
LukeTowers Aug 21, 2020
a25567c
Use the same resizing process for FileModels that's used for everythi…
LukeTowers Aug 21, 2020
38718e0
Fixed bug where FileModel images wouldn't properly store their config…
LukeTowers Aug 21, 2020
779a879
Added support for new "image" column type that uses the ImageResizer …
LukeTowers Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/DESIGN_DOCS/resizer.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// Moved logic into appropriate locations now
6 changes: 6 additions & 0 deletions config/cms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,12 @@
'path' => '/storage/app/media',
],

'resized' => [
'disk' => 'local',
'folder' => 'resized',
'path' => '/storage/app/resized',
],

],

/*
Expand Down
Loading