Finish the "october:util purge uploads" artisan command #4518
Conversation
Credit to @austinderrick for the initial implementation (#4029)
| @@ -294,7 +295,57 @@ protected function utilPurgeUploads() | |||
| return; | |||
| } | |||
|
|
|||
| // @todo | |||
| $totalCount = 0; | |||
| $uploadsPath = Config::get('filesystems.disks.local.root', storage_path('app')) . '/uploads'; | |||
There was a problem hiding this comment.
@bennothommo just an idea, maybe it would be useful to take uploads path from configs?
There was a problem hiding this comment.
@w20k Good idea, will change it around soon.
There was a problem hiding this comment.
@bennothommo did you implement that suggestion?
There was a problem hiding this comment.
@LukeTowers not yet, still on the to-do list.
|
@LukeTowers I'm gonna move this to 461. I have realised that this feature is only covering local filesystems currently, yet uploads can be stored on remote filesystems. Given this, I will need to re-do the command to also allow purging of uploads on remote filesystems. |
bennothommo
added
Status: In Progress
Status: On Hold
and removed
Status: Review Needed
labels
|
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
Only works for uploads stored on the local disk right now, support for remote disks may be added in the future at some point. Replaces #4518 & #4029. Credit to @LukeTowers, @bennothommo, & @austinderrick.
|
Implemented in 7fde924 |
LukeTowers
added
Status: Completed
and removed
Status: In Progress
Status: On Hold
labels
Continues and finishes the work done by @austinderrick in #4029.
Finishes the functionality for the
october:util purge uploadscommand. This had to be done on a new branch as @austinderrick's original PR had diverged from thedevelopbranch and couldn't be properly merged.