Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dirvers plugin] Upgrade dependent to make Dirvers plugin compatible with php7.4 #5409

Closed
everyx opened this issue Dec 16, 2020 · 3 comments · Fixed by octoberrain/drivers-plugin#8
Closed

[Dirvers plugin] Upgrade dependent to make Dirvers plugin compatible with php7.4 #5409

everyx opened this issue Dec 16, 2020 · 3 comments · Fixed by octoberrain/drivers-plugin#8
Labels
Status: Completed Type: Maintenance
Milestone
v1.1.2

Comments

@everyx
Copy link
Contributor

everyx commented Dec 16, 2020

  • OctoberCMS Build: v1.1.1
  • PHP Version: 7.4
  • Database Engine: MySQL
  • Plugins Installed:
    Ompmega.MixHelper,
    Martin.Forms,
    Mohsin.txt,
    VojtaSvoboda.TwigExtensions,
    October.Drivers,
    Zaxbux.DOStorageDriver

Description:

We need upgrade dependent version of aws/aws-sdk-php version to 3.128.1 or later.
image

Steps To Reproduce:

install plugin and user digitalocean storage filesystem disk.
@everyx everyx mentioned this issue Dec 16, 2020
Closed
@LukeTowers
Copy link
Contributor

@everyx please submit a PR to the Drivers plugin here: https://github.com/octoberrain/drivers-plugin including a bump to the version.yaml and the composer requirements.

@LukeTowers LukeTowers reopened this Dec 16, 2020
@LukeTowers LukeTowers added this to the v1.1.2 milestone Dec 16, 2020
@everyx everyx mentioned this issue Dec 17, 2020
Merged
@everyx
Copy link
Contributor Author

everyx commented Dec 17, 2020

@everyx please submit a PR to the Drivers plugin here: https://github.com/octoberrain/drivers-plugin including a bump to the version.yaml and the composer requirements.

@LukeTowers PR just created, please review and merge. :)

LukeTowers pushed a commit to octoberrain/drivers-plugin that referenced this issue Dec 17, 2020
@everyx
fix: upgrade aws sdk to be compatible with php7.4 (#8)
d2cf16a 
Fixes octobercms/october#5409
@LukeTowers
Copy link
Contributor

@everyx done! Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Type: Maintenance
Milestone
v1.1.2
Development

Successfully merging a pull request may close this issue.

fix: upgrade aws sdk to be compatible with php7.4
2 participants
@everyx @LukeTowers