Toggle features based on what the remotely configured sensor version supports #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaneti1
approved these changes
Oct 5, 2023
| } | ||
| } | ||
| if sensorMetadataForVersion == nil { |
There was a problem hiding this comment.
What is expected to happen in such case? I guess this means no sensor version was matched right? Do we want to return an error for that?
There was a problem hiding this comment.
Initially I thought we should return error as well and abandon the change, but the following convinced me otherwise:
- For customers, the common case is to use the valid versions. We already do a check on the backend when creating the Change - and if the version is semantic, we require that we know about it (so this check here should never be nil). If the version is not semantic, we assume that it is a special version for the customer so we allow the flow to go through - but that should be a rare case for hotfixes or private betas. We don't expect customers to use versions not in the list otherwise.
- For development flows, this check doesn't make sense as you often have sensor versions that are not in the "main" list and that is OK
So for these cases we assume nothing about the feature support and leave them as-is. Of course, the customer might make an invalid change but we can't verify that.
BenRub
pushed a commit
that referenced
this pull request
Oct 19, 2023
meori
pushed a commit
that referenced
this pull request
Oct 22, 2023
BenRub
pushed a commit
that referenced
this pull request
Oct 31, 2023
ltsonov-cb
deleted the
CNS-3719-toggle-features-based-on-sensor-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by product, the remote configurator should prioritize ease-of-use and automatically enable/disable features that the new sensor version supports (if it is provided).