CNS-1284-Add CRI-O support to the cluster scanner #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CR. Instead, values can be used to override the defaults from code, similar to how the rest of the Engine spec works.
BenRub
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few additional mounts on the node-agent's cluster scanner.
These mounts provide access to the CRI-O's image storage area via the filesystem - since CRI does not define interfaces to access image content directly; therefore we can't scan the image via the socket.
The values for all 3 mounts can be overridden if the cluster is not using the defaults for some reason (advanced users only). We will not support edge cases where different nodes need different mounts, at least for now.