remove Number#toNumberFixed

octarine-public · Oct 28, 2024 · bd303f3 · bd303f3
1 parent 28fa82c
commit bd303f3
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 18 deletions.
diff --git a/octarine.d.ts b/octarine.d.ts
@@ -60,15 +60,6 @@ declare interface Number {
 	 */
 	/** popcnt */
 	bitCount(): number
-	/**
-	 * @requires
-	 * `import "github.com/octarine-public/wrapper/global"` or
-	 * `import { ... } from "github.com/octarine-public/wrapper/index"`
-	 * @param {number} [fractionDigits=3]
-	 *
-	 * @returns {number}
-	 */
-	toNumberFixed(fractionDigits?: number): number
 	/**
 	 * @requires
 	 * `import "github.com/octarine-public/wrapper/global"` or

diff --git a/prototypes/number.ts b/prototypes/number.ts
@@ -11,10 +11,6 @@ Number.prototype.hasMask = function (mask: number): boolean {
 	return ((this as number) & mask) === mask
 }
 
-Number.prototype.toNumberFixed = function (fractionDigits = 3): number {
-	return parseFloat((this as number).toFixed(fractionDigits))
-}
-
 Number.prototype.bitCount = function (): number {
 	let n = this as number
 	n = n - ((n >> 1) & 0x55555555)

diff --git a/wrapper/Managers/Monitors/UnitChanged.ts b/wrapper/Managers/Monitors/UnitChanged.ts
@@ -20,7 +20,7 @@ const Monitor = new (class CPreUnitChanged {
 			const unit = Units[index]
 			// see: https://dota2.fandom.com/wiki/Health_Regeneration
 			unit.HPRegenCounter += unit.HPRegen * 0.1
-			const regenAmount = Math.round(unit.HPRegenCounter.toNumberFixed(1))
+			const regenAmount = Math.floor(unit.HPRegenCounter * 10) / 10
 			unit.HPRegenCounter -= regenAmount
 			unit.HPPrediction = Math.max(Math.min(unit.MaxHP, unit.HP + regenAmount), 0)
 			if (!unit.IsVisible) {

diff --git a/wrapper/Objects/Base/Projectile.ts b/wrapper/Objects/Base/Projectile.ts
@@ -88,7 +88,6 @@ export class TrackingProjectile extends Projectile {
 			this.Position.Invalidate()
 		}
 	}
-
 	public get IsDodgeable(): boolean {
 		return this.dodgeable
 	}
@@ -98,7 +97,7 @@ export class TrackingProjectile extends Projectile {
 	public get ExpireTime(): number {
 		return this.expireTime
 	}
-
+	/** @internal */
 	public Update(
 		targetEntity: Nullable<Unit | FakeUnit>,
 		speed: number,

diff --git a/wrapper/Objects/Base/Unit.ts b/wrapper/Objects/Base/Unit.ts
@@ -1052,6 +1052,7 @@ export class Unit extends Entity {
 			}
 		}
 	}
+
 	public GetAmplificationDamage(
 		_source: Unit,
 		_damageType: DAMAGE_TYPES,
@@ -1090,8 +1091,8 @@ export class Unit extends Entity {
 
 	// TODO: damage
 	public GetDamageBlockers(): Modifier[] {
-		// for (let index = this.Buffs.length - 1; index > -1; index--) {
-		// 	const buff = this.Buffs[index]
+		// for (let i = this.Buffs.length - 1; i > -1; i--) {
+		// 	const buff = this.Buffs[i]
 		// }
 		return []
 	}