Make robotjs context-aware for electron 14+ #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electron 14+ refuse to load robotjs on the renderer See electron/electron#18397 for details Signed-off-by: Christoph Settgast <[email protected]>
|
@octalmage I successfully tested this with electron 14, kindly review and merge. Thank you in advance! |
|
@oktapodia I successfully tested this with electron 14, kindly review and merge. |
csett86
added a commit
to jitsi/jitsi-meet-electron-sdk
that referenced
this pull request
Nov 4, 2021
Will be reverted as soon as octalmage/robotjs#696 is merged upstream.
|
Instead of this you can also directly go to Node-API with #697, Node-API is also context-aware. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron 14+ refuse to load robotjs on the renderer
See electron/electron#18397 for details
Closes: #580