-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get and set display name for XOpenDisplay() #34
Closed
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
360ffb4
get and set display name for XOpenDisplay()
jub3i b4e215f
improve variable names, move hasDisplayNameChanged reset
jub3i 4275976
better argument parsing
jub3i b2e3341
change function style, matching rest of code
jub3i 6ed295c
fix os compatibility
jub3i File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,14 @@ | |
#include <nan.h> | ||
#include <v8.h> | ||
#include <vector> | ||
#include "string.h" | ||
#include "mouse.h" | ||
#include "deadbeef_rand.h" | ||
#include "keypress.h" | ||
#include "screen.h" | ||
#include "screengrab.h" | ||
#include "MMBitmap.h" | ||
#include "xdisplay.h" | ||
|
||
using namespace v8; | ||
|
||
|
@@ -472,6 +474,26 @@ NAN_METHOD(getScreenSize) | |
NanReturnValue(obj); | ||
} | ||
|
||
NAN_METHOD(getXDisplayName) | ||
{ | ||
NanScope(); | ||
NanReturnValue(NanNew<String>(getXDisplay())); | ||
} | ||
|
||
NAN_METHOD(setXDisplayName) | ||
{ | ||
NanScope(); | ||
|
||
//Convert arg to c-string | ||
//NOTE: surely better way to go from v8::String to char* ? | ||
std::string name = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this feels pretty dirty, you know better way to accomplish? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should work!
|
||
std::string(*v8::String::Utf8Value(args[0]->ToString())); | ||
char *display_name = strdup(name.c_str()); | ||
|
||
setXDisplay(display_name); | ||
NanReturnUndefined(); | ||
} | ||
|
||
void init(Handle<Object> target) | ||
{ | ||
|
||
|
@@ -505,6 +527,12 @@ void init(Handle<Object> target) | |
target->Set(NanNew<String>("getScreenSize"), | ||
NanNew<FunctionTemplate>(getScreenSize)->GetFunction()); | ||
|
||
target->Set(NanNew<String>("getXDisplayName"), | ||
NanNew<FunctionTemplate>(getXDisplayName)->GetFunction()); | ||
|
||
target->Set(NanNew<String>("setXDisplayName"), | ||
NanNew<FunctionTemplate>(setXDisplayName)->GetFunction()); | ||
|
||
} | ||
|
||
NODE_MODULE(robotjs, init) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably cause errors on other OSes, right?