-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This commit fixes #148: Volume keys don't work on Mac. #171
Conversation
Also added brightness, keyboard illumination, play/pause, next/previous
The failure doesn't seem to be related to the commit. =/ |
@gurel I restarted the build and it passed! Usually just a connection issue. ANYWAY. This looks great! Can't wait to test it. Thanks for making this happen! |
There is also something that can be done, which is to map STOP key to PAUSE since there is no stop key on macs. Although it may give more consistency around multiple operating systems. |
@@ -6,6 +6,8 @@ | |||
|
|||
#if defined(IS_MACOSX) | |||
#include <ApplicationServices/ApplicationServices.h> | |||
#import <IOKit/hidsystem/IOHIDLib.h> | |||
#import <IOKit/hidsystem/ev_keymap.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind fixing this? These should be hard tabs.
Hope this update should covers all the hard tab indents. The IDE default of my javascript editor is spaces. Kinda skipped my mind =). |
Awesome! I'll get this merged today. Thanks again, this is so great. |
Wow this is a ton of fun. How did you come up with this fix? I'm having trouble finding documentation about it. Do you know if this will cause any issues on older versions of Mac OS X? Like Yosemite or Mavericks? Thanks! |
Wow nevermind, IOKit goes back far. I'll get this released! |
I found an issue, the keycodes for the multimedia keys overlap with other keys. For example, for the letter "a", keyCodeRequiresSystemDefinedEvent returns 1. I'm going to give them special keycodes so we can convert them. |
Here are the keycodes:
|
Fixed in #180! Released in RobotJS v0.4.1. |
Sorry for the late reply, somehow the notification aren't working. Well it actually wasn't easy to find, but i stumbled to a few solutions: |
This commit fixes #148: Volume keys don't work on Mac.
Also added brightness, keyboard illumination, play/pause, next/previous