fix for #97, mouseScroll Windows XP #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion on top of function
|
Thanks a ton! I've fixed this same issue with a bunch of PRs, but missed this one. We're considering dropping XP support but for now, why not support it! |
octalmage
added a commit
that referenced
this pull request
Feb 18, 2016
fix for #97, mouseScroll Windows XP
|
@octalmage as long as Windows XP support does not interfere with other stuff we can support it I guess. |
|
Well in this case he's on Windows 10 with VS 2008. I'm pretty sure the screen capture code doesn't support XP anyway. I know it drops Node 0.8 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mouse scroll on Windows XP, see #97.
C89 (2008 redistributables (XP)) requires variable declarations to be on top of a block. Newer versions have better support for C99, which is more flexible in this.
Tested with 2008 redistributables on Windows 10.