chore: enable eslint and clean #46
Conversation
|
One quick suggestion: perhaps a github action could be setup to lint code style on pull requests / push to prevent entropy from doing it's thing? |
That is what lefthook does. It runs the lint on pre-submit |
| @@ -28,22 +29,21 @@ var allPlayers = {}; | |||
|
|
|||
| function statsInitialized() { | |||
| return new Promise(function (resolve) { | |||
| (function waitForInitialStatsToBeGenerated(){ | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
The original function ran repeatedly until stats != null, now it only runs once.
| @@ -185,8 +191,7 @@ function init(dbname, options) { | |||
| debug('Database is ready'); | |||
| }).catch(function(error) { | |||
| console.error('Failed to initialise database(s)'); | |||
| console.error(error); | |||
| process.exit(1); | |||
| throw new Error(error); | |||
There was a problem hiding this comment.
Throwing within a promise.catch() block does not exit the process. I think process.exit is the only option here.
| function updateResults(gameData) { | ||
| debug('Updating results for finished game'); | ||
|
|
||
| for (let player of gameData.playerRank) { | ||
| for (const player of gameData.playerRank) { | ||
| if (player === 'ai') { |
There was a problem hiding this comment.
I never knew you could use const in a for of block. I learned something :)
| else if (action === 'income') { | ||
| return (8+5) << 4; | ||
| } | ||
| else if (action == 'change-team') { |
There was a problem hiding this comment.
Bad merge here - you lost some code.
| action = 'income'; | ||
| break; | ||
| case 6: |
| "line-comment-position": "off", | ||
| "linebreak-style": [ | ||
| "error", | ||
| "windows" |
There was a problem hiding this comment.
I develop on Linux, so this rule needs to go.
No description provided.