Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Option to implement OCaml strings with JavaScript strings #1772

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

vouillon
Copy link
Member

  • Conditional compilation of Wasm runtime
  • Import string constants (define JS strings in Wasm runtime)
  • default should be not to use js strings
  • Compatibilty for when JS string builtins proposal is not available
  • Performance improvements
    • skip conversions for ASCII strings
    • lower level version of caml_blit_string
    • Use I16 array for conversions
    • Remove unnecessary conversion
  • clean-up / check for missing tests
  • adapt Jane street libraries
  • performance measurements

Use method subarray rather than slice.
@vouillon vouillon force-pushed the js-strings branch 4 times, most recently from e9a1f85 to 4242cfa Compare December 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant