-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Option to implement OCaml strings with JavaScript strings #1772
Draft
vouillon
wants to merge
14
commits into
master
Choose a base branch
from
js-strings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vouillon
commented
Dec 17, 2024
- Conditional compilation of Wasm runtime
- Import string constants (define JS strings in Wasm runtime)
- default should be not to use js strings
- Compatibilty for when JS string builtins proposal is not available
- Performance improvements
- skip conversions for ASCII strings
- lower level version of caml_blit_string
- Use I16 array for conversions
- Remove unnecessary conversion
- clean-up / check for missing tests
- adapt Jane street libraries
- performance measurements
Use method subarray rather than slice.
vouillon
force-pushed
the
js-strings
branch
4 times, most recently
from
December 18, 2024 20:03
e9a1f85
to
4242cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.