Remove *.opam.template #1753
Remove *.opam.template #1753
Conversation
Signed-off-by: Sora Morimoto <[email protected]>
|
The CI doesn't like this change. |
smorimoto
force-pushed
the
cleanup-opam-templates
branch
4 times, most recently
from
ac99e8f to
88e32d4
Compare
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
cleanup-opam-templates
branch
from
88e32d4 to
ed805f7
Compare
|
|
||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| steps: | ||
| - name: Set git to use LF | ||
| if: matrix.ocaml-compiler < 5.2 | ||
| if: matrix.os == 'windows-latest' |
There was a problem hiding this comment.
I don't understand this change. ocaml-compiler < 5.2 was on purpose.
| dune-cache: true | ||
| opam-pin: false | ||
|
|
||
| - run: opam install conf-pkg-config |
There was a problem hiding this comment.
We need this, this is a temporary fix for dra27/mingw-w64-shims#1
| - name: build doc | ||
| if: ${{ !matrix.skip-doc && github.event_name == 'push' && github.ref_name == 'master'}} | ||
| - name: Build doc | ||
| if: matrix.os == 'ubuntu-latest' && matrix.ocaml-compiler == '5.2' && github.event_name == 'push' && github.ref_name == 'master' |
There was a problem hiding this comment.
I would prefer to only bump version once when it come to change the version we generate the doc with.
| - "5.0" | ||
| - "5.1" | ||
| skip-test: |
There was a problem hiding this comment.
I find the previous version much easier to understand.
There was a problem hiding this comment.
This PR kind of inline the logic previously encoded by skip-* parameters. We know have to go over all step understand what's done for what version. I think this is going in the wrong direction.
|
Can you please explain why you want to remove opam.template and try to keep the diff minimal in the CI |
|
I was going to remove the excess as much as possible, but as you said, it was not as elegant as I expected. |
No description provided.