Use dune test stanza #1631
Merged
Use dune test stanza #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
tests
branch
4 times, most recently
from
887bb01 to
a1c0e4a
Compare
|
I'm guessing the relevant dune PR is ocaml/dune#10671, in which case this PR is blocked until dune 3.17 is released (https://github.com/ocaml/dune/milestone/58) |
|
xref ocaml/dune#11143 |
|
@vouillon, can you rebase this PR using the latest version of dune 3.17 ? I think they've drop the change that caused most dune file to be reformatted. |
|
I plan to merge this PR before merging #1724 |
hhugo
reviewed
Dec 2, 2024
| @@ -6,6 +6,8 @@ | |||
| (executable | |||
| (name test) | |||
| (modules test) | |||
| (enabled_if | |||
| (<> %{profile} using-effects)) | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires some fixes in dune...