Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CONTRIBUTION guide, PR Templates #956

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Updating CONTRIBUTION guide, PR Templates #956

merged 3 commits into from
Feb 5, 2024

Conversation

floydtree
Copy link
Contributor

@floydtree floydtree commented Feb 5, 2024 •
edited
Loading

Related Issue: n/a

Description of changes:

  1. Updating PR template, contribution guide. adding references to changelog file
  2. Adding a codeowners file, to add default reviewers to PRs. In the future we can update this for specific paths in repo.

@floydtree floydtree added documentation Improvements or additions to documentation enhancement New feature or request maintainers Issues that require attention from all maintainers labels Feb 5, 2024
zschmerber
zschmerber approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aniak5
Aniak5 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@pagbabian-splunk pagbabian-splunk merged commit 596fd07 into ocsf:main Feb 5, 2024
2 checks passed
@floydtree floydtree deleted the docu-updates branch February 5, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagbabian-splunk pagbabian-splunk pagbabian-splunk approved these changes

@zschmerber zschmerber zschmerber approved these changes

@Aniak5 Aniak5 Aniak5 approved these changes

@mikeradka mikeradka Awaiting requested review from mikeradka mikeradka is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request maintainers Issues that require attention from all maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@floydtree @Aniak5 @zschmerber @pagbabian-splunk