Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional UID attribute to Certificate object #840

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

nathanbvail
Copy link
Contributor

Related Issue: 838

Description of changes:

Updated the certificate object to include an optional UID attribute. This will allow certificate names to be captured in logs.

image

@nathanbvail nathanbvail marked this pull request as ready for review November 2, 2023 16:08
@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Nov 2, 2023
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @nathanbvail !

@floydtree floydtree merged commit d28accf into ocsf:main Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants