-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name property to scrip.json object. #1284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelJurka
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
December 12, 2024 13:23
davemcatcisco
requested changes
Dec 12, 2024
PavelJurka
force-pushed
the
Add-name-to-script
branch
from
December 17, 2024 17:09
34985ac
to
2071e4a
Compare
davemcatcisco
previously approved these changes
Dec 17, 2024
jonrau-at-queryai
previously approved these changes
Dec 17, 2024
mikeradka
previously approved these changes
Dec 17, 2024
Signed-off-by: Pavel Jurka <[email protected]>
PavelJurka
dismissed stale reviews from mikeradka, jonrau-at-queryai, and davemcatcisco
via
December 18, 2024 09:41
4e5fe2e
PavelJurka
requested review from
davemcatcisco,
mikeradka and
jonrau-at-queryai
December 18, 2024 09:43
davemcatcisco
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving after merge-out invalidated previous approval.
floydtree
approved these changes
Dec 18, 2024
mikeradka
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added name field to script object.
Typical usage - the name of the customer script in an excel sheet.