Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand osint object #1168

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Expand osint object #1168

merged 4 commits into from
Aug 30, 2024

Conversation

jonrau-at-queryai
Copy link
Contributor

Description of changes:

  • Add a handful of objects into the osint object: file, reputation, subnet, script
  • Add an additional enum to osint.type_id for File
  • Update Captions and Descriptions to reflect changes

@mikeradka mikeradka added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.4.0 or later Changes marked for versions beyond v1.3.0 of OCSF labels Aug 27, 2024
mikeradka
mikeradka previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks Jonathan.

@floydtree floydtree requested a review from mikeradka August 29, 2024 15:40
@jonrau-at-queryai jonrau-at-queryai self-assigned this Aug 29, 2024
@jonrau-at-queryai jonrau-at-queryai added discovery Issues related to Discovery Category grammar_consistency Issues related to the attribute grammar consistency work-stream labels Aug 29, 2024
query-jeremy
query-jeremy approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@query-jeremy query-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jon!

@query-jeremy query-jeremy merged commit c1ea8ff into ocsf:main Aug 30, 2024
3 checks passed
@jonrau-at-queryai jonrau-at-queryai deleted the osint-expansion branch September 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@query-jeremy query-jeremy query-jeremy approved these changes

@mikeradka mikeradka mikeradka approved these changes

@floydtree floydtree floydtree approved these changes

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

@Aniak5 Aniak5 Awaiting requested review from Aniak5 Aniak5 is a code owner

@zschmerber zschmerber Awaiting requested review from zschmerber zschmerber is a code owner

Assignees

@jonrau-at-queryai jonrau-at-queryai

Labels
discovery Issues related to Discovery Category enhancement New feature or request grammar_consistency Issues related to the attribute grammar consistency work-stream non_breaking Non Breaking, backwards compatible changes v1.4.0 or later Changes marked for versions beyond v1.3.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonrau-at-queryai @floydtree @mikeradka @query-jeremy