-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor addition to the cvss object #1165
Merged
floydtree
merged 3 commits into
ocsf:main
from
floydtree:vulnerability_object_additions
Aug 21, 2024
Merged
Minor addition to the cvss object #1165
floydtree
merged 3 commits into
ocsf:main
from
floydtree:vulnerability_object_additions
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajas Panat <[email protected]>
floydtree
added
enhancement
New feature or request
findings
Issues related to Findings Category
v1.4.0 or later
Changes marked for versions beyond v1.3.0 of OCSF
labels
Aug 21, 2024
floydtree
requested review from
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
August 21, 2024 15:44
Signed-off-by: Rajas Panat <[email protected]>
irakledibm
previously approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small spelling mistake in a CHANGELOG: vendor_namr
. Not a big deal.
jonrau-at-queryai
previously approved these changes
Aug 21, 2024
mikeradka
previously requested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - minor typo in the CHANGELOG
. Otherwise looks good.
Signed-off-by: Rajas Panat <[email protected]>
floydtree
dismissed stale reviews from jonrau-at-queryai and irakledibm
via
August 21, 2024 16:57
8bc139e
jonrau-at-queryai
approved these changes
Aug 21, 2024
mikeradka
approved these changes
Aug 21, 2024
jcburgo
approved these changes
Aug 21, 2024
irakledibm
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
findings
Issues related to Findings Category
v1.4.0 or later
Changes marked for versions beyond v1.3.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
Description of changes:
vendor_name
to thecvss
object to help represent the source/vendor that provided the cvss scores.