Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding state_id IDs #1143

Merged
merged 15 commits into from
Jul 30, 2024
Merged

adding state_id IDs #1143

merged 15 commits into from
Jul 30, 2024

Conversation

SashaSelin
Copy link
Contributor

Related Issue:
Missing enable/disable state Ids

Description of changes:
added state id's to Device Config State Change Class.

Signed-off-by: Sasha Selin (Cyrebro) ([email protected])

Following closed PR #1076 (#1076), Ive created new PR to create disable/enable state to "device_config_state_change" class.

state “disable/enable” is very common when it comes to FortiGate logs, especially where the subtype=”system” and action=”add”.
The “status” field on this type of logs are represent the “cfgattr” (Configuration value changed) status.

Raw log for example:

<118>date=2024-05-01 time=11:43:38 devname="Test for OCSF" devid="FG11256985563" eventtime=1714553018203018280 tz="+0300" logid="0100044547" type="event" subtype="system" level="information" vd="North" logdesc="Object attribute configured" user="SashaS" ui="GUI(192.168.190.54)" action="Add" cfgtid=10691505 cfgpath="firewall.policy" cfgobj="136" cfgattr="status[disable]srcintf[OCSF-Test]dstintf[OCSF-Test]srcaddr[Sasha-selin-ocsf-test]dstaddr[Sasha-selin]srcaddr6[]dstaddr6[]src-vendor-mac[]action[accept]schedule[always]service[RDP]groups[]users[]fsso-groups[]comments[ (Copy of 148)]custom-log-fields[]" msg="Add firewall.policy 136"

image

@mikeradka mikeradka added the v1.3.0 Changes marked for v1.3.0 of OCSF label Jul 26, 2024
@floydtree floydtree requested a review from jasonbreimer July 26, 2024 18:59
@mikeradka mikeradka added the discovery Issues related to Discovery Category label Jul 26, 2024
floydtree
floydtree previously approved these changes Jul 30, 2024
zschmerber
zschmerber previously approved these changes Jul 30, 2024
@floydtree floydtree dismissed stale reviews from pagbabian-splunk, zschmerber, and themself via a7616c2 July 30, 2024 16:12
mikeradka
mikeradka previously approved these changes Jul 30, 2024
Copy link
Contributor

@jasonbreimer jasonbreimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these two attributes makes a lot of sense.

@pagbabian-splunk pagbabian-splunk merged commit 856af7c into ocsf:main Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Issues related to Discovery Category v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants