Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to load_balancer object #1138

Merged
merged 12 commits into from
Jul 26, 2024
Merged

Enhancement to load_balancer object #1138

merged 12 commits into from
Jul 26, 2024

Conversation

pagbabian-splunk
Copy link
Contributor

@pagbabian-splunk pagbabian-splunk commented Jul 2, 2024

Related Issue: N/A (from Slack)

Description of changes:

Added ip to the load_balancer object. Added Load Balancer to the endpoint type_id enum list.

irakledibm
irakledibm previously approved these changes Jul 3, 2024
objects/load_balancer.json Outdated Show resolved Hide resolved
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to the description of the new attribute, as discussed in the line specific comments.

@floydtree floydtree added enhancement New feature or request v1.3.0 Changes marked for v1.3.0 of OCSF non_breaking Non Breaking, backwards compatible changes labels Jul 10, 2024
zschmerber
zschmerber previously approved these changes Jul 23, 2024
floydtree
floydtree previously approved these changes Jul 23, 2024
mikeradka
mikeradka previously approved these changes Jul 23, 2024
pagbabian-splunk added 2 commits July 23, 2024 09:33
CHANGELOG.md Outdated Show resolved Hide resolved
@mikeradka mikeradka self-requested a review July 23, 2024 17:46
Aniak5
Aniak5 previously approved these changes Jul 25, 2024
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mikeradka
mikeradka previously approved these changes Jul 26, 2024
zschmerber
zschmerber previously approved these changes Jul 26, 2024
@floydtree floydtree dismissed stale reviews from zschmerber, mikeradka, and Aniak5 via 2096473 July 26, 2024 18:17
@mikeradka mikeradka merged commit e651e9d into main Jul 26, 2024
2 checks passed
@mikeradka mikeradka deleted the load_balancer branch July 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants