-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement to load_balancer object #1138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint type_id enum list. Signed-off-by: Paul Agbabian <[email protected]>
pagbabian-splunk
requested review from
floydtree,
Aniak5,
mikeradka and
zschmerber
as code owners
July 2, 2024 22:06
Signed-off-by: Paul Agbabian <[email protected]>
irakledibm
previously approved these changes
Jul 3, 2024
Aniak5
reviewed
Jul 3, 2024
floydtree
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates to the description of the new attribute, as discussed in the line specific comments.
floydtree
added
enhancement
New feature or request
v1.3.0
Changes marked for v1.3.0 of OCSF
non_breaking
Non Breaking, backwards compatible changes
labels
Jul 10, 2024
Signed-off-by: pagbabian-splunk <[email protected]>
zschmerber
previously approved these changes
Jul 23, 2024
floydtree
previously approved these changes
Jul 23, 2024
mikeradka
previously approved these changes
Jul 23, 2024
Signed-off-by: pagbabian-splunk <[email protected]>
Signed-off-by: pagbabian-splunk <[email protected]>
pagbabian-splunk
dismissed stale reviews from mikeradka, floydtree, and zschmerber
via
July 23, 2024 16:37
5ad91f3
Signed-off-by: Paul Agbabian <[email protected]>
floydtree
requested changes
Jul 23, 2024
Signed-off-by: pagbabian-splunk <[email protected]>
…nto load_balancer
mikeradka
approved these changes
Jul 24, 2024
Aniak5
previously approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mikeradka
previously approved these changes
Jul 26, 2024
zschmerber
previously approved these changes
Jul 26, 2024
Signed-off-by: Rajas <[email protected]>
floydtree
dismissed stale reviews from zschmerber, mikeradka, and Aniak5
via
July 26, 2024 18:17
2096473
floydtree
approved these changes
Jul 26, 2024
zschmerber
approved these changes
Jul 26, 2024
mikeradka
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
non_breaking
Non Breaking, backwards compatible changes
v1.3.0
Changes marked for v1.3.0 of OCSF
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A (from Slack)
Description of changes:
Added ip to the load_balancer object. Added Load Balancer to the endpoint type_id enum list.