-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Startup Application Query event class in the discovery category. #1119
Conversation
…s used to report startup applications on endpoint devices.
Signed-off-by: maxhotta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a number of concerns about this PR:
- If scheduled tasks/jobs are a supported startup application type (and they seem to be because
Scheduled
is one of the values instart_type_id
) then thefile
andcmd_line
attributes should not berequired
andrecommended
respectively because Windows scheduled tasks don't necessarily have an associated executable file or command line. Also, thetype_id
enum should have an entry for a scheduled task/job. - Is there a reason why
run_mode
isn'trun_mode_id
with a correspondingrun_mode
companion attribute? start_type_id
should cross-referencestart_type
in itssibling
property.- Instead of having attributes like
start_type_id
,cmd_line
,file
,run_state_id
, etc. thestartup_app
object could (should?) reuse existing object types that describe the same properties of the relevent entities. For example,startup_app
could have awin_service
attribute that would apply when thetype_id
isService
. It could have aschedule_job
attribute that would apply when thetype_id
isScheduled Job
. This would avoid thestartup_app
object having lots of required attributes that don't make sense for certain values oftype_id
.
@davemcatcisco Per further discussion on your point 4, the consensus was to use a 'just one' constraint on the different types that the startup_app could be, and add objects (as you suggest) to model the startup_app type. I will revise, and post an update with these changes. |
- Add objects that map to items in type_id - Include a just_one clause for these objects - Updated run_mode for consistency
# Conflicts: # CHANGELOG.md
Signed-off-by: maxhotta <[email protected]>
Incorporated most items, except for adding the win_service object as one of the options for the target startup application. |
I've fixed the schema validation issue by 'patching' the startup_app object in windows extensions (per committee discussion). There was an issue in defining the constraints in the patched startup_app object which includes win_service. To address this, I've defined win_service and its corresponding constraint in the core startup_app object. |
…ts with a new event added in main)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for addressing my picky comments. And my apologies for missing the notification asking me to re-review.
The Startup Application Query class captures the results of a discovery on target devices.
This class was refactored from a previous submission, while incorporating feedback from Paul.
Description of changes:
Made the Startup Application object more clear by factoring out unrelated items in the type_id list.
The list now describes only the type of application.
A run_mode attribute was added as an array to capture the other items.
Also added a run_state to capture the state of the application at the time the event was logged.