Adds protobuf encoding #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floydtree
previously approved these changes
May 31, 2024
zschmerber
previously approved these changes
May 31, 2024
dkolbly
force-pushed
the
dkolbly/protobuf-encoding
branch
from
2a2cfe9 to
9441781
Compare
|
The Of particular interest for this purpose is the internal metaschema model here: and the actual protobuf SDK which consumes a schema in that format and produces .proto: The README.md there also documents how exactly it was generated Current version of tool at |
mlmitch
reviewed
Jun 11, 2024
|
Looks good to me. I'm sure whatever you decide to take out of linting will be appropriate. |
zschmerber
previously approved these changes
Aug 1, 2024
rmouritzen-splunk
requested changes
Aug 1, 2024
Signed-off-by: Donovan Kolbly <[email protected]>
- use well-known types for `json_t` and `object` - mark non-required fields as optional Signed-off-by: Donovan Kolbly <[email protected]>
Signed-off-by: Donovan Kolbly <[email protected]>
Also adds a proto/buf.yaml to configuring linting tweaks. To run the linter, install [buf](https://buf.build/docs/installation) and run, from the `proto/` directory: ``` buf lint ``` there are some known linting issues for certain non-standard enumerations that don't follow the 0=Unknown convention. Signed-off-by: Donovan Kolbly <[email protected]>
Signed-off-by: Donovan Kolbly <[email protected]>
dkolbly
force-pushed
the
dkolbly/protobuf-encoding
branch
from
aac0662 to
7012c94
Compare
zschmerber
approved these changes
Aug 15, 2024
rmouritzen-splunk
approved these changes
Aug 15, 2024
floydtree
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a protobuf encoding for OCSF