-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup for release on PyPI #44
Conversation
Another advantage with (Later more on the other points...) |
Good point. From what I understand, |
author = 'Thomas Breuel', | ||
author_email = '[email protected]', | ||
url = 'https://github.com/tmbdev/hocr-tools', | ||
download_url = 'https://github.com/tmbdev/hocr-tools/tarball/' + VERSION, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need here the v
as well, e.g. something like
https://github.com/zuphilip/hocr-tools/tarball/v0.3.2
which just redirects to
https://codeload.github.com/zuphilip/hocr-tools/legacy.tar.gz/v0.3.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it.
description = 'Advanced tools for hOCR integration', | ||
author = 'Thomas Breuel', | ||
author_email = '[email protected]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also make sense to add here
maintainer = '',
maintainer_email = '',
with the credentials of one of us. 😇 Do you volunteer @kba? We could also discuss this separately if you prefer.
Perfect. Thank you! I will squash+merge in the next minutes. |
Requirements are still open. |
Looks good for me. Let me know when it is ready to merge+squash. |
It should work now, we can always improve it. |
Once the tools are versioned (#43), they can be released to PyPI for easy installation with pip.
Uploading a source distribution basically works with the configuration in this PR.
Open Questions:
Name:That is not really a problem, seems to be fairly common actually.hocr-tools
with a dash is possible but if the project is properly packaged in the future (Make hocr-tools a proper module #42), it would be wise to have a name that is a valid module nameWhat to put inI removed the author_email, PyPI warns on register but still carries out the upload, at least for test.author
/author_email
? I started with @tmbdev's credentialssetup.py
or inrequirements.txt
? Could be both, discussed hereWho manages the uploads?I will