Fix compat with windows by adding savefile argument to hocr-pdf #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng windows compat
Added option to hocr-pdf to output to a file (instead of stdout) fixi…
|
Thank you! |
stweil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get hocr-pdf to work in windows because it outputs to stdout and windows doesn't handle the latin1 encoding very well (and created corrupt PDFs for me even when using
chcp 65001andset PYTHONIOENCODING=utf-8) . I was able to get this to work by adding an optional argument for which file to save the document to (instead of outputting to stdout).I would have preferred to use a Linux OS but the company I work for uses windows servers. This update makes it work for both without having to deal with the encoding headache.