Request Response Syncrnization across threads and Replay/Observer updates #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the sendRequest validation that only allows one of each type to be in the queue. May make this a toggle as the protections are probably wanted for new users
As it appears to only matter for each response type, allow only one to be running at a time and then allow the next one
Having no abilities is actually a valid state for some units
Add a method to set the perspective as well as a method to set what units by unit or tag that we are following
|
And... I also just relized I forgot to squash all my commits down... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Query calls to allow multiple requests of the same type by syncronizing them across multiple threads instead of just erroring out.
I then got distracted by Replay and Observer things and adjusted the library so that it is actually able to do everything or nearly everything that the C++ AutoObserver library is able to do.