Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitTypeData.hasMinerals is bugged #23

Closed
Ketroc opened this issue May 5, 2020 · 0 comments
Closed

UnitTypeData.hasMinerals is bugged #23

Ketroc opened this issue May 5, 2020 · 0 comments
Assignees
@ocraft
Labels
bug

Comments

@Ketroc
Copy link
Contributor

Ketroc commented May 5, 2020 •
edited
Loading

line58 of UnitTypeData is:

this.hasMinerals = (Boolean)((Optional)DataExtractor.tryGet(SC2APIProtocol.Data.UnitTypeData::getHasVespene, SC2APIProtocol.Data.UnitTypeData::hasHasMinerals).apply(sc2ApiUnitTypeData)).orElse(false);

probably just needs to be changed to getHasMinerals
@ocraft ocraft self-assigned this May 5, 2020
@ocraft ocraft added the bug label May 5, 2020
ocraft added a commit that referenced this issue May 5, 2020
@ocraft
#23 Fixed invalid mapping for UnitTypeData.hasMinerals.
17d5f7b
@ocraft ocraft closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocraft ocraft

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ketroc @ocraft